From 0801a9db1645264ca3da17a66bdbc1523921544d Mon Sep 17 00:00:00 2001 From: sowle Date: Thu, 7 Jan 2021 18:21:52 +0300 Subject: [PATCH] coretests: chain_switching_when_out_spent_in_alt_chain_mixin added, exposes a bug --- tests/core_tests/chain_switch_1.cpp | 56 +++++++++++++++++++++++++++++ tests/core_tests/chain_switch_1.h | 5 +++ tests/core_tests/chaingen_main.cpp | 2 ++ 3 files changed, 63 insertions(+) diff --git a/tests/core_tests/chain_switch_1.cpp b/tests/core_tests/chain_switch_1.cpp index 2657ba5c..72732b18 100644 --- a/tests/core_tests/chain_switch_1.cpp +++ b/tests/core_tests/chain_switch_1.cpp @@ -622,3 +622,59 @@ bool alt_blocks_with_the_same_txs::check_tx_not_related_to_altblock(currency::co return true; } +//----------------------------------------------------------------------------------------------------- + +bool chain_switching_when_out_spent_in_alt_chain_mixin::generate(std::vector& events) const +{ + // Test idea: + bool r = false; + GENERATE_ACCOUNT(miner_acc); + GENERATE_ACCOUNT(alice_acc); + GENERATE_ACCOUNT(bob_acc); + MAKE_GENESIS_BLOCK(events, blk_0, miner_acc, test_core_time::get_time()); + MAKE_NEXT_BLOCK(events, blk_1, blk_0, miner_acc); + REWIND_BLOCKS_N(events, blk_1r, blk_1, miner_acc, CURRENCY_MINED_MONEY_UNLOCK_WINDOW); + + // 0 1 11 12 13 14 + // (0 )- (1 )-...(1r)- (2 )- (3 )- + // \ + // \ + // \- (2a)- (3a)- (4a)- + // tx_0 <- tx_1 // tx_1 spends output from tx_0 + + // send batch of 10 x 5 test coins to Alice for easier tx_0 construction + transaction tx_0; + r = construct_tx_with_many_outputs(events, blk_1r, miner_acc.get_keys(), alice_acc.get_public_address(), MK_TEST_COINS(50), 10, + TESTS_DEFAULT_FEE, tx_0); + CHECK_AND_ASSERT_MES(r, false, "construct_tx_with_many_outputs failed"); + events.push_back(tx_0); + + MAKE_NEXT_BLOCK(events, blk_2, blk_1r, miner_acc); + MAKE_NEXT_BLOCK(events, blk_3, blk_2, miner_acc); + + MAKE_NEXT_BLOCK_TX1(events, blk_2a, blk_1r, miner_acc, tx_0); + + // make sure Alice received exactly 50 test coins + CREATE_TEST_WALLET(alice_wlt, alice_acc, blk_0); + REFRESH_TEST_WALLET_AT_GEN_TIME(events, alice_wlt, blk_2a, CURRENCY_MINED_MONEY_UNLOCK_WINDOW + 2); + CHECK_TEST_WALLET_BALANCE_AT_GEN_TIME(alice_wlt, MK_TEST_COINS(50)); + + // Alice spends her 5 test coint received by tx_0 + MAKE_TX_FEE_MIX(events, tx_1, alice_acc, bob_acc, MK_TEST_COINS(4), TESTS_DEFAULT_FEE, 3 /* nmix */, blk_2a); + events.pop_back(); // pop back tx_1 as it won't go into the tx pool normally because of alt chain + + // simulate handling a block with that tx: handle tx like going with the block... + events.push_back(event_visitor_settings(event_visitor_settings::set_txs_kept_by_block, true)); + events.push_back(tx_1); + events.push_back(event_visitor_settings(event_visitor_settings::set_txs_kept_by_block, false)); + + MAKE_NEXT_BLOCK_TX1(events, blk_3a, blk_2a, miner_acc, tx_1); + MAKE_NEXT_BLOCK(events, blk_4a, blk_3a, miner_acc); + + // make sure Alice has correct balance + REFRESH_TEST_WALLET_AT_GEN_TIME(events, alice_wlt, blk_4a, 2); + CHECK_TEST_WALLET_BALANCE_AT_GEN_TIME(alice_wlt, MK_TEST_COINS(45)); + + + return true; +} diff --git a/tests/core_tests/chain_switch_1.h b/tests/core_tests/chain_switch_1.h index 0605a5d2..36375f72 100644 --- a/tests/core_tests/chain_switch_1.h +++ b/tests/core_tests/chain_switch_1.h @@ -72,3 +72,8 @@ struct alt_blocks_with_the_same_txs : public test_chain_unit_enchanced bool check_tx_related_to_altblock(currency::core& c, size_t ev_index, const std::vector& events); bool check_tx_not_related_to_altblock(currency::core& c, size_t ev_index, const std::vector& events); }; + +struct chain_switching_when_out_spent_in_alt_chain_mixin : public test_chain_unit_enchanced +{ + bool generate(std::vector& events) const; +}; diff --git a/tests/core_tests/chaingen_main.cpp b/tests/core_tests/chaingen_main.cpp index 15a3fb43..e9a1f1ab 100644 --- a/tests/core_tests/chaingen_main.cpp +++ b/tests/core_tests/chaingen_main.cpp @@ -899,6 +899,8 @@ int main(int argc, char* argv[]) GENERATE_AND_PLAY(gen_simple_chain_split_1); GENERATE_AND_PLAY(alt_blocks_validation_and_same_new_amount_in_two_txs); GENERATE_AND_PLAY(alt_blocks_with_the_same_txs); + GENERATE_AND_PLAY(chain_switching_when_out_spent_in_alt_chain_mixin); + // miscellaneous tests GENERATE_AND_PLAY(test_blockchain_vs_spent_keyimges);