Charon/blockchain
1
0
Fork 0
forked from lthn/blockchain
Code Pull requests Activity

fixed a rare race condition in get_coinbase_hash_cached() 2

Browse source
This commit is contained in:
sowle 2025-05-22 15:50:18 +03:00
parent cebeebe730
commit 43bde5aa99
No known key found for this signature in database
GPG key ID: C07A24B2D89D49FC
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/currency_core/blockchain_storage_basic.h
View file

@ -203,7 +203,7 @@ namespace currency
if (bei.m_cache_coinbase_state == 2)
{
// state is 2, cache must be ready, access the cache
std::shared_ptr<crypto::hash> local_coinbase_id = bei.m_cache_coinbase_id;
std::shared_ptr<crypto::hash> local_coinbase_id = std::atomic_load(&bei.m_cache_coinbase_id);
CHECK_AND_ASSERT_THROW_MES(local_coinbase_id, "internal error: m_cache_coinbase_id is empty");
return *local_coinbase_id;
}
@ -213,7 +213,7 @@ namespace currency
{
// state has just been 0, now 1, we're calculating
std::shared_ptr<crypto::hash> ptr_h = std::make_shared<crypto::hash>(get_transaction_hash(bei.bl.miner_tx));
std::atomic_store(&bei.m_cache_coinbase_id, ptr_h);
std::atomic_store(&bei.m_cache_coinbase_id, ptr_h); // when moving to C++20 consider to change this to atomic shared ptr -- sowle
bei.m_cache_coinbase_state.store(2);
return *ptr_h;
}