From 653b05298b22a9a3a9e200cd73314bd97bf4f43a Mon Sep 17 00:00:00 2001 From: sowle Date: Sat, 28 Dec 2024 00:27:16 +0100 Subject: [PATCH] coretests: hard_fork_5_tx_version implemented --- tests/core_tests/hard_fork_5.cpp | 79 ++++++++++++++++++++++++++++---- tests/core_tests/hard_fork_5.h | 4 +- 2 files changed, 73 insertions(+), 10 deletions(-) diff --git a/tests/core_tests/hard_fork_5.cpp b/tests/core_tests/hard_fork_5.cpp index 8a88658a..bd0cd4df 100644 --- a/tests/core_tests/hard_fork_5.cpp +++ b/tests/core_tests/hard_fork_5.cpp @@ -7,26 +7,87 @@ using namespace currency; +hard_fork_5_tx_version::hard_fork_5_tx_version() +{ + REGISTER_CALLBACK_METHOD(hard_fork_5_tx_version, c1); +} + bool hard_fork_5_tx_version::generate(std::vector& events) const { // - // Test idea: + // Test idea: ensure that the correct tx.hardfork_id is required after HF5. // + bool r = false; uint64_t ts = test_core_time::get_time(); - GENERATE_ACCOUNT(miner_acc); - GENERATE_ACCOUNT(alice_acc); + m_accounts.resize(TOTAL_ACCS_COUNT); + account_base& miner_acc = m_accounts[MINER_ACC_IDX]; miner_acc.generate(); miner_acc.set_createtime(ts); + account_base& alice_acc = m_accounts[ALICE_ACC_IDX]; alice_acc.generate(); alice_acc.set_createtime(ts); MAKE_GENESIS_BLOCK(events, blk_0, miner_acc, ts); - //// rebuild genesis miner tx - //std::vector destinations; - //destinations.emplace_back(MK_TEST_COINS(1), alice_acc.get_public_address()); - //destinations.emplace_back(MK_TEST_COINS(1), alice_acc.get_public_address()); - //CHECK_AND_ASSERT_MES(replace_coinbase_in_genesis_block(destinations, generator, events, blk_0), false, ""); // leftover amount will be also send to miner - DO_CALLBACK(events, "configure_core"); // default configure_core callback will initialize core runtime config with m_hardforks REWIND_BLOCKS_N_WITH_TIME(events, blk_0r, blk_0, miner_acc, CURRENCY_MINED_MONEY_UNLOCK_WINDOW + 3); + // make a simple tx just to check HF5 tx.hardfork_id rule basic validity MAKE_TX(events, tx_1, miner_acc, alice_acc, MK_TEST_COINS(1), blk_0r); + MAKE_NEXT_BLOCK_TX1(events, blk_1, blk_0r, miner_acc, tx_1); + + // + // construct a tx with an incorrect hardfork_id and make sure it won't be accepted by either the tx pool or the core + // + std::vector sources; + std::vector destinations; + + r = fill_tx_sources_and_destinations(events, blk_1, miner_acc, alice_acc, MK_TEST_COINS(7), TX_DEFAULT_FEE, 4, sources, destinations); + CHECK_AND_ASSERT_MES(r, false, "fill_tx_sources_and_destinations failed"); + + transaction tx_2{}; + size_t tx_hardfork_id{}; + uint64_t tx_version = get_tx_version_and_hardfork_id(get_block_height(blk_1) + 1, m_hardforks, tx_hardfork_id); + size_t incorrect_tx_hardfork_id = 0; + r = construct_tx(miner_acc.get_keys(), sources, destinations, empty_attachment, tx_2, tx_version, incorrect_tx_hardfork_id, 0); // note using incorrect hardfork id here + CHECK_AND_ASSERT_MES(r, false, "construct_tx failed"); + // mark as invalid, shouldn't be accepted by the tx pool + DO_CALLBACK(events, "mark_invalid_tx"); + ADD_CUSTOM_EVENT(events, tx_2); + + // now add tx_2 as 'kept_by_block', with tx pool checks turned off + ADD_CUSTOM_EVENT(events, event_visitor_settings(event_visitor_settings::set_txs_kept_by_block, true)); + events.push_back(tx_2); // now tx should be accepted by the pool + ADD_CUSTOM_EVENT(events, event_visitor_settings(event_visitor_settings::set_txs_kept_by_block, false)); + // the block shouldn't be accepted, because of invalid tx_2 + DO_CALLBACK(events, "mark_invalid_block"); + MAKE_NEXT_BLOCK_TX1(events, blk_2_bad, blk_1, miner_acc, tx_2); + + + // + // reconstruct the same tx, now using the correct tx_hardfork_id, and make sure it will be accepted + // + tx_2 = transaction{}; + r = construct_tx(miner_acc.get_keys(), sources, destinations, empty_attachment, tx_2, tx_version, tx_hardfork_id, 0); + CHECK_AND_ASSERT_MES(r, false, "construct_tx failed"); + ADD_CUSTOM_EVENT(events, tx_2); + MAKE_NEXT_BLOCK_TX1(events, blk_2, blk_1, miner_acc, tx_2); + + REWIND_BLOCKS_N_WITH_TIME(events, blk_2r, blk_2, miner_acc, CURRENCY_MINED_MONEY_UNLOCK_WINDOW); + + // epilogue + + DO_CALLBACK(events, "c1"); + + return true; +} + +bool hard_fork_5_tx_version::c1(currency::core& c, size_t ev_index, const std::vector &events) +{ + std::shared_ptr alice_wlt = init_playtime_test_wallet(events, c, ALICE_ACC_IDX); + + CHECK_AND_ASSERT_MES(c.get_pool_transactions_count() == 0, false, "Incorrect txs count in the pool"); + + size_t blocks_fetched = 0; + alice_wlt->refresh(blocks_fetched); + CHECK_AND_ASSERT_EQ(blocks_fetched, 2 * CURRENCY_MINED_MONEY_UNLOCK_WINDOW + 5); + + CHECK_AND_ASSERT_MES(check_balance_via_wallet(*alice_wlt.get(), "alice_wlt", MK_TEST_COINS(8)), false, ""); return true; } diff --git a/tests/core_tests/hard_fork_5.h b/tests/core_tests/hard_fork_5.h index 692d3348..61c79c48 100644 --- a/tests/core_tests/hard_fork_5.h +++ b/tests/core_tests/hard_fork_5.h @@ -6,7 +6,9 @@ #include "wallet_tests_basic.h" -struct hard_fork_5_tx_version : public test_chain_unit_enchanced +struct hard_fork_5_tx_version : public wallet_test { + hard_fork_5_tx_version(); bool generate(std::vector& events) const; + bool c1(currency::core& c, size_t ev_index, const std::vector &events); };