From 3acd7667bc73d27988ee9dacc78e3c123c5b2fc7 Mon Sep 17 00:00:00 2001
From: cryptozoidberg <crypto.zoidberg@gmail.com>
Date: Fri, 22 Mar 2024 18:44:31 +0100
Subject: [PATCH] fix for uninitialized data on transaction details(including
 fee) in unconfirmed transactions

---
 src/wallet/wallet2.cpp                  |  1 +
 src/wallet/wallet_public_structs_defs.h | 26 ++++++++++++-------------
 2 files changed, 14 insertions(+), 13 deletions(-)

diff --git a/src/wallet/wallet2.cpp b/src/wallet/wallet2.cpp
index b2af9d58..aac7839a 100644
--- a/src/wallet/wallet2.cpp
+++ b/src/wallet/wallet2.cpp
@@ -4706,6 +4706,7 @@ void wallet2::get_unconfirmed_transfers(std::vector<wallet_public::wallet_transf
       continue;
     }
     trs.push_back(u.second);
+    load_wallet_transfer_info_flags(trs.back());
   }
 }
 //----------------------------------------------------------------------------------------------------
diff --git a/src/wallet/wallet_public_structs_defs.h b/src/wallet/wallet_public_structs_defs.h
index 6610bb7d..523aa2d4 100644
--- a/src/wallet/wallet_public_structs_defs.h
+++ b/src/wallet/wallet_public_structs_defs.h
@@ -134,17 +134,17 @@ namespace wallet_public
 
   struct wallet_transfer_info
   {
-    uint64_t      timestamp;
-    crypto::hash  tx_hash;
-    uint64_t      height;          //if height == 0 then tx is unconfirmed
-    uint64_t      unlock_time;
-    uint32_t      tx_blob_size;
+    uint64_t      timestamp = 0;
+    crypto::hash  tx_hash = currency::null_hash;
+    uint64_t      height = 0;          //if height == 0 then tx is unconfirmed
+    uint64_t      unlock_time = 0;
+    uint32_t      tx_blob_size = 0;
     std::string   payment_id;
     std::string   comment;
-    bool          is_service;
-    bool          is_mixing;
-    bool          is_mining;
-    uint64_t      tx_type;
+    bool          is_service = false;
+    bool          is_mixing = false;
+    bool          is_mining = false;
+    uint64_t      tx_type = 0;
     employed_tx_entries employed_entries;
     std::vector<currency::tx_service_attachment> service_entries;
     std::vector<std::string> remote_addresses;  //optional
@@ -153,11 +153,11 @@ namespace wallet_public
     std::vector<wallet_sub_transfer_info> subtransfers;
 
     //not included in streaming serialization
-    uint64_t      fee;
-    bool          show_sender;
+    uint64_t      fee = 0;
+    bool          show_sender = false;
     std::vector<escrow_contract_details> contract;
-    uint16_t      extra_flags;
-    uint64_t      transfer_internal_index;
+    uint16_t      extra_flags = 0;
+    uint64_t      transfer_internal_index = 0;
    
     //not included in kv serialization map
     currency::transaction tx;