Charon/blockchain
1
0
Fork 0
forked from lthn/blockchain
Code Pull requests Activity

Capture remote_ip by value in try_ping lambda

Browse source 
The lambda in try_ping now captures remote_ip by value instead of accessing context.m_remote_ip directly. This ensures the correct IP is used even if the context changes before the lambda executes.
This commit is contained in:
Snider 2025-10-05 18:01:59 +01:00
parent c2c130a076
commit 7f930b0fec
1 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/p2p/net_node.inl
View file

@ -1565,17 +1565,18 @@ namespace nodetool
{
peerid_type peer_id_l = arg.node_data.peer_id;
uint32_t port_l = arg.node_data.my_port;
uint32_t remote_ip = context.m_remote_ip;
//try ping to be sure that we can add this peer to peer_list
try_ping(arg.node_data, context, [peer_id_l, port_l, context, this]()
try_ping(arg.node_data, context, [peer_id_l, port_l, remote_ip, this]()
{
//called only(!) if success pinged, update local peerlist
peerlist_entry pe;
pe.adr.ip = context.m_remote_ip;
pe.adr.ip = remote_ip;
pe.adr.port = port_l;
time(&pe.last_seen);
pe.id = peer_id_l;
this->m_peerlist.append_with_peer_white(pe);
LOG_PRINT_L2("PING SUCCESS " << string_tools::get_ip_string_from_int32(context.m_remote_ip) << ":" << port_l);
LOG_PRINT_L2("PING SUCCESS " << string_tools::get_ip_string_from_int32(remote_ip) << ":" << port_l);
});
}