From ba6252ed58d875cb61e27420dbcb900dc42ee01b Mon Sep 17 00:00:00 2001 From: Snider Date: Tue, 30 Sep 2025 12:01:38 +0100 Subject: [PATCH] AI Code Review Fixes --- Makefile | 2 +- cmake/CPackConfig.cmake | 2 +- src/config/default.cmake | 1 - src/p2p/net_node.inl | 6 +++--- 4 files changed, 5 insertions(+), 6 deletions(-) diff --git a/Makefile b/Makefile index 4004b639..45ff0799 100644 --- a/Makefile +++ b/Makefile @@ -98,7 +98,7 @@ static-release: conan-profile-detect @echo "Building profile: release-static" CONAN_HOME=$(CONAN_CACHE) conan install . --output-folder=build/release-static --build=missing -s build_type=$(BUILD_TYPE) cmake -S . -B build/release-static -DCMAKE_TOOLCHAIN_FILE=build/release-static/conan_toolchain.cmake -DCMAKE_BUILD_TYPE=$(BUILD_TYPE) -D STATIC=ON -DTESTNET=$(TESTNET) - cmake --build build/release-static --config=Release --parallel=$(CPU_CORES) + cmake --build build/release-static --config=$(BUILD_TYPE) --parallel=$(CPU_CORES) conan-profile-detect: @if [ ! -f "$(DEFAULT_CONAN_PROFILE)" ]; then \ diff --git a/cmake/CPackConfig.cmake b/cmake/CPackConfig.cmake index a55201a7..4140328c 100644 --- a/cmake/CPackConfig.cmake +++ b/cmake/CPackConfig.cmake @@ -59,7 +59,7 @@ if(CMAKE_BUILD_TYPE STREQUAL "Release") set(CPACK_PACKAGE_DIRECTORY "${CMAKE_BINARY_DIR}/packages") install(FILES README.md LICENSE.txt - DESTINATION . + DESTINATION "share/doc/${CPACK_PACKAGE_NAME}" ) set(_arch "${CMAKE_SYSTEM_PROCESSOR}") diff --git a/src/config/default.cmake b/src/config/default.cmake index ab52cc1f..5c9fbe1f 100644 --- a/src/config/default.cmake +++ b/src/config/default.cmake @@ -33,7 +33,6 @@ if (TESTNET) set(stratum_default_port 36940 CACHE STRING "STRATUM_DEFAULT_PORT" ) set(package_name "lethean-testnet-cli" CACHE STRING "CPACK_PACKAGE_NAME" ) else () - message(CHECK_FAIL "bad") set(p2p_default_port 36942 CACHE STRING "P2P_DEFAULT_PORT" ) set(rpc_default_port 36941 CACHE STRING "RPC_DEFAULT_PORT" ) set(stratum_default_port 36940 CACHE STRING "STRATUM_DEFAULT_PORT" ) diff --git a/src/p2p/net_node.inl b/src/p2p/net_node.inl index aa09c384..2f1df0e2 100644 --- a/src/p2p/net_node.inl +++ b/src/p2p/net_node.inl @@ -434,8 +434,8 @@ namespace nodetool { #ifndef TESTNET //TODO: - //ADD_HARDCODED_SEED_NODE(std::string("0.0.0.0:") + std::to_string(P2P_DEFAULT_PORT)); - //ADD_HARDCODED_SEED_NODE("95.217.43.225", P2P_DEFAULT_PORT); + ADD_HARDCODED_SEED_NODE(std::string("0.0.0.0:") + std::to_string(P2P_DEFAULT_PORT)); + ADD_HARDCODED_SEED_NODE("116.202.82.115", P2P_DEFAULT_PORT); //ADD_HARDCODED_SEED_NODE("94.130.137.230", P2P_DEFAULT_PORT); //ADD_HARDCODED_SEED_NODE("95.217.42.247", P2P_DEFAULT_PORT); //ADD_HARDCODED_SEED_NODE("94.130.160.115", P2P_DEFAULT_PORT); @@ -445,7 +445,7 @@ namespace nodetool //ADD_HARDCODED_SEED_NODE("144.76.183.143", P2P_DEFAULT_PORT); #else // TESTNET - //ADD_HARDCODED_SEED_NODE("95.217.43.225", P2P_DEFAULT_PORT); + ADD_HARDCODED_SEED_NODE("116.202.82.115", P2P_DEFAULT_PORT); //ADD_HARDCODED_SEED_NODE("94.130.137.230", P2P_DEFAULT_PORT); //ADD_HARDCODED_SEED_NODE("95.217.42.247", P2P_DEFAULT_PORT); //ADD_HARDCODED_SEED_NODE("94.130.160.115", P2P_DEFAULT_PORT);