Charon/blockchain
1
0
Fork 0
forked from lthn/blockchain
Code Pull requests Activity

Some minor issues are fixed (#212)

Browse source 
* It's just waste of resources to use temp variable to call static members

also, according to docs, QString::fromStdString already take care about utf8 conversion,
so there is no need to do std::string -> C string -> QString conversion.

* Don't try use tray actions if tray is not available.

It just leads to the crash.
This commit is contained in:
Sergey Radionov 2020-09-05 22:29:41 +07:00 • committed by GitHub
parent 8b8bbf3247
commit f24e271119
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/gui/qt-daemon/application/mainwindow.cpp
View file

@ -941,9 +941,12 @@ QString MainWindow::set_localization_strings(const QString param)
else
{
m_localization = lr.strings;
m_quit_action->setText(QString().fromUtf8(m_localization[localization_id_quit].c_str()));
m_restore_action->setText(QString().fromUtf8(m_localization[localization_id_tray_menu_show].c_str()));
m_minimize_action->setText(QString().fromUtf8(m_localization[localization_id_tray_menu_minimize].c_str()));
if(m_quit_action)
m_quit_action->setText(QString::fromStdString(m_localization[localization_id_quit]));
if(m_restore_action)
m_restore_action->setText(QString::fromStdString(m_localization[localization_id_tray_menu_show]));
if(m_minimize_action)
m_minimize_action->setText(QString::fromStdString(m_localization[localization_id_tray_menu_minimize]));
resp.error_code = API_RETURN_CODE_OK;
LOG_PRINT_L0("New localization set, language title: " << lr.language_title << ", strings " << lr.strings.size());
}