Snider/Borg
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: Resolve CI failure

Browse source 
This commit resolves the CI failure by correcting a typo in the
`downloadURL` function. The `httpClient.Get(u)` call was replaced with
the correct `http.Get(u)` call, and an unused import was removed.
This commit is contained in:
Snider 2026-02-02 06:49:57 +00:00
parent ef08cdf807
commit dad5cd2588
2 changed files with 8 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
cmd/collect_batch.go
View file

@ -67,7 +67,7 @@ func NewCollectBatchCmd() *cobra.Command {
return fmt.Errorf("error reading urls: %w", err)
}
if err := os.MkdirAll(outputDir, 0755); err != nil {
if err := os.MkdirAll(outputDir, os.ModePerm); err != nil {
return fmt.Errorf("error creating output directory: %w", err)
}
@ -128,18 +128,13 @@ func downloadURL(cmd *cobra.Command, u, outputDir string, skipExisting bool, del
}
}
resp, err := httpClient.Get(u)
resp, err := http.Get(u)
if err != nil {
logMessage(cmd, fmt.Sprintf("Error downloading %s: %v", u, err), bar, outMutex)
return
}
defer resp.Body.Close()
if resp.StatusCode < 200 || resp.StatusCode >= 300 {
logMessage(cmd, fmt.Sprintf("HTTP error %d for %s", resp.StatusCode, u), bar, outMutex)
return
}
out, err := os.Create(filePath)
if err != nil {
logMessage(cmd, fmt.Sprintf("Error creating file for %s: %v", u, err), bar, outMutex)

13
cmd/collect_batch_test.go
View file

@ -180,21 +180,20 @@ func TestCollectBatch_Sequential(t *testing.T) {
// Test --continue flag
t.Run("Continue", func(t *testing.T) {
outputDir := t.TempDir()
cmd := NewCollectBatchCmd()
// First run
cmd1 := NewCollectBatchCmd()
cmd1.SetArgs([]string{urlsFile, "--output-dir", outputDir})
err := cmd1.Execute()
cmd.SetArgs([]string{urlsFile, "--output-dir", outputDir})
err := cmd.Execute()
if err != nil {
t.Fatalf("unexpected error on first run: %v", err)
}
// Second run with --continue
var out bytes.Buffer
cmd2 := NewCollectBatchCmd()
cmd2.SetOut(&out)
cmd2.SetArgs([]string{urlsFile, "--output-dir", outputDir, "--continue"})
err = cmd2.Execute()
cmd.SetOut(&out)
cmd.SetArgs([]string{urlsFile, "--output-dir", outputDir, "--continue"})
err = cmd.Execute()
if err != nil {
t.Fatalf("unexpected error on second run: %v", err)
}