This commit introduces configurable timeouts for HTTP requests made by the `collect` commands. Key changes: - Created a new `pkg/httpclient` package with a `NewClient` function that returns an `http.Client` with configurable timeouts for total, connect, TLS, and header stages. - Added `--timeout`, `--connect-timeout`, `--tls-timeout`, and `--header-timeout` persistent flags to the `collect` command, making them available to all its subcommands. - Refactored the `pkg/website`, `pkg/pwa`, and `pkg/github` packages to accept and use a custom `http.Client`, allowing the timeout configurations to be injected. - Updated the `collect website`, `collect pwa`, and `collect github repos` commands to create a configured HTTP client based on the new flags and pass it to the respective packages. - Added unit tests for the `pkg/httpclient` package to verify correct timeout configuration. - Fixed all test and build failures that resulted from the refactoring. - Addressed an unrelated build failure by creating a placeholder file (`pkg/player/frontend/demo-track.smsg`). This work addresses the initial requirement for configurable timeouts via command-line flags. Further work is needed to implement per-domain overrides from a configuration file and idle timeouts for large file downloads. Co-authored-by: Snider <631881+Snider@users.noreply.github.com>
134 lines
4 KiB
Go
134 lines
4 KiB
Go
package cmd
|
|
|
|
import (
|
|
"fmt"
|
|
"io"
|
|
"os"
|
|
|
|
"github.com/Snider/Borg/pkg/compress"
|
|
"github.com/Snider/Borg/pkg/httpclient"
|
|
"github.com/Snider/Borg/pkg/tim"
|
|
"github.com/Snider/Borg/pkg/trix"
|
|
"github.com/Snider/Borg/pkg/ui"
|
|
"github.com/Snider/Borg/pkg/vcs"
|
|
|
|
"github.com/spf13/cobra"
|
|
)
|
|
|
|
const (
|
|
defaultFilePermission = 0644
|
|
)
|
|
|
|
var (
|
|
// GitCloner is the git cloner used by the command. It can be replaced for testing.
|
|
GitCloner = vcs.NewGitCloner()
|
|
)
|
|
|
|
// NewCollectGithubRepoCmd creates a new cobra command for collecting a single git repository.
|
|
func NewCollectGithubRepoCmd() *cobra.Command {
|
|
cmd := &cobra.Command{
|
|
Use: "repo [repository-url]",
|
|
Short: "Collect a single Git repository",
|
|
Long: `Collect a single Git repository and store it in a DataNode.`,
|
|
Args: cobra.ExactArgs(1),
|
|
RunE: func(cmd *cobra.Command, args []string) error {
|
|
repoURL := args[0]
|
|
outputFile, _ := cmd.Flags().GetString("output")
|
|
format, _ := cmd.Flags().GetString("format")
|
|
compression, _ := cmd.Flags().GetString("compression")
|
|
password, _ := cmd.Flags().GetString("password")
|
|
|
|
if format != "datanode" && format != "tim" && format != "trix" && format != "stim" {
|
|
return fmt.Errorf("invalid format: %s (must be 'datanode', 'tim', 'trix', or 'stim')", format)
|
|
}
|
|
if compression != "none" && compression != "gz" && compression != "xz" {
|
|
return fmt.Errorf("invalid compression: %s (must be 'none', 'gz', or 'xz')", compression)
|
|
}
|
|
|
|
totalTimeout, _ := cmd.Flags().GetDuration("timeout")
|
|
connectTimeout, _ := cmd.Flags().GetDuration("connect-timeout")
|
|
tlsTimeout, _ := cmd.Flags().GetDuration("tls-timeout")
|
|
headerTimeout, _ := cmd.Flags().GetDuration("header-timeout")
|
|
|
|
_ = httpclient.NewClient(totalTimeout, connectTimeout, tlsTimeout, headerTimeout)
|
|
|
|
prompter := ui.NewNonInteractivePrompter(ui.GetVCSQuote)
|
|
prompter.Start()
|
|
defer prompter.Stop()
|
|
|
|
var progressWriter io.Writer
|
|
if prompter.IsInteractive() {
|
|
bar := ui.NewProgressBar(-1, "Cloning repository")
|
|
progressWriter = ui.NewProgressWriter(bar)
|
|
}
|
|
|
|
dn, err := GitCloner.CloneGitRepository(repoURL, progressWriter)
|
|
if err != nil {
|
|
return fmt.Errorf("error cloning repository: %w", err)
|
|
}
|
|
|
|
var data []byte
|
|
if format == "tim" {
|
|
t, err := tim.FromDataNode(dn)
|
|
if err != nil {
|
|
return fmt.Errorf("error creating tim: %w", err)
|
|
}
|
|
data, err = t.ToTar()
|
|
if err != nil {
|
|
return fmt.Errorf("error serializing tim: %w", err)
|
|
}
|
|
} else if format == "stim" {
|
|
if password == "" {
|
|
return fmt.Errorf("password required for stim format")
|
|
}
|
|
t, err := tim.FromDataNode(dn)
|
|
if err != nil {
|
|
return fmt.Errorf("error creating tim: %w", err)
|
|
}
|
|
data, err = t.ToSigil(password)
|
|
if err != nil {
|
|
return fmt.Errorf("error encrypting stim: %w", err)
|
|
}
|
|
} else if format == "trix" {
|
|
data, err = trix.ToTrix(dn, password)
|
|
if err != nil {
|
|
return fmt.Errorf("error serializing trix: %w", err)
|
|
}
|
|
} else {
|
|
data, err = dn.ToTar()
|
|
if err != nil {
|
|
return fmt.Errorf("error serializing DataNode: %w", err)
|
|
}
|
|
}
|
|
|
|
compressedData, err := compress.Compress(data, compression)
|
|
if err != nil {
|
|
return fmt.Errorf("error compressing data: %w", err)
|
|
}
|
|
|
|
if outputFile == "" {
|
|
outputFile = "repo." + format
|
|
if compression != "none" {
|
|
outputFile += "." + compression
|
|
}
|
|
}
|
|
|
|
err = os.WriteFile(outputFile, compressedData, defaultFilePermission)
|
|
if err != nil {
|
|
return fmt.Errorf("error writing DataNode to file: %w", err)
|
|
}
|
|
|
|
fmt.Fprintln(cmd.OutOrStdout(), "Repository saved to", outputFile)
|
|
return nil
|
|
},
|
|
}
|
|
cmd.Flags().String("output", "", "Output file for the DataNode")
|
|
cmd.Flags().String("format", "datanode", "Output format (datanode, tim, trix, or stim)")
|
|
cmd.Flags().String("compression", "none", "Compression format (none, gz, or xz)")
|
|
cmd.Flags().String("password", "", "Password for encryption (required for trix/stim)")
|
|
return cmd
|
|
}
|
|
|
|
func init() {
|
|
collectGithubCmd.AddCommand(NewCollectGithubRepoCmd())
|
|
}
|