43f3904072
This commit addresses several issues identified in a code review to improve the overall quality and robustness of the application. Key changes include: - Added safe type assertions with `nil` checks when retrieving the logger from the context to prevent panics. - Moved the `bar.Finish()` call to be inside the loop in the `all` command, so each progress bar finishes after its corresponding repository is cloned. - Added a check for context cancellation at the start of the pagination loop in the GitHub client to prevent unnecessary API calls. - Ensured the authenticated client is used consistently, even when falling back to the organization endpoint. - Added `nil` checks for the progress bar parameter in the `website` and `pwa` packages to prevent panics. - Updated the `golang.org/x/oauth2` dependency to a patched release to address a reported vulnerability.
69 lines
1.8 KiB
Go
69 lines
1.8 KiB
Go
package cmd
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"log/slog"
|
|
"os"
|
|
"strings"
|
|
|
|
"github.com/Snider/Borg/pkg/github"
|
|
"github.com/Snider/Borg/pkg/ui"
|
|
"github.com/Snider/Borg/pkg/vcs"
|
|
|
|
"github.com/spf13/cobra"
|
|
)
|
|
|
|
// allCmd represents the all command
|
|
var allCmd = &cobra.Command{
|
|
Use: "all [user/org]",
|
|
Short: "Collect all public repositories from a user or organization",
|
|
Long: `Collect all public repositories from a user or organization and store them in a DataNode.`,
|
|
Args: cobra.ExactArgs(1),
|
|
Run: func(cmd *cobra.Command, args []string) {
|
|
logVal := cmd.Context().Value("logger")
|
|
log, ok := logVal.(*slog.Logger)
|
|
if !ok || log == nil {
|
|
fmt.Fprintln(os.Stderr, "Error: logger not properly initialised")
|
|
return
|
|
}
|
|
repos, err := github.GetPublicRepos(context.Background(), args[0])
|
|
if err != nil {
|
|
log.Error("failed to get public repos", "err", err)
|
|
return
|
|
}
|
|
|
|
outputDir, _ := cmd.Flags().GetString("output")
|
|
|
|
for _, repoURL := range repos {
|
|
log.Info("cloning repository", "url", repoURL)
|
|
bar := ui.NewProgressBar(-1, "Cloning repository")
|
|
|
|
dn, err := vcs.CloneGitRepository(repoURL, bar)
|
|
bar.Finish()
|
|
if err != nil {
|
|
log.Error("failed to clone repository", "url", repoURL, "err", err)
|
|
continue
|
|
}
|
|
|
|
data, err := dn.ToTar()
|
|
if err != nil {
|
|
log.Error("failed to serialize datanode", "url", repoURL, "err", err)
|
|
continue
|
|
}
|
|
|
|
repoName := strings.Split(repoURL, "/")[len(strings.Split(repoURL, "/"))-1]
|
|
outputFile := fmt.Sprintf("%s/%s.dat", outputDir, repoName)
|
|
err = os.WriteFile(outputFile, data, 0644)
|
|
if err != nil {
|
|
log.Error("failed to write datanode to file", "url", repoURL, "err", err)
|
|
continue
|
|
}
|
|
}
|
|
},
|
|
}
|
|
|
|
func init() {
|
|
RootCmd.AddCommand(allCmd)
|
|
allCmd.PersistentFlags().String("output", ".", "Output directory for the DataNodes")
|
|
}
|