a242080299
This commit introduces a resilient, configurable retry mechanism for network requests. Key changes include: - A new `pkg/retry` package with a custom `http.Transport` that implements exponential backoff and jitter. - Integration of the retry transport into the `website`, `pwa`, and `github` packages to handle transient network failures gracefully. - New persistent CLI flags (`--retries`, `--retry-backoff`, `--retry-max`, `--retry-jitter`, `--no-retry`) to allow user configuration of the retry behavior. - The flag-handling logic has been moved to a `PersistentPreRun` function to ensure user-provided values are parsed correctly. - A basic retry mechanism has been added to the `vcs` package for git clone operations. - Added unit tests for the retry transport. This work is in progress, with the next steps being to implement support for the `Retry-After` header and unify the VCS retry logic with the global configuration. Co-authored-by: Snider <631881+Snider@users.noreply.github.com>
93 lines
2.4 KiB
Go
93 lines
2.4 KiB
Go
package github
|
|
|
|
import (
|
|
"bytes"
|
|
"context"
|
|
"fmt"
|
|
"io"
|
|
"net/http"
|
|
"strings"
|
|
|
|
"github.com/Snider/Borg/pkg/retry"
|
|
"github.com/google/go-github/v39/github"
|
|
)
|
|
|
|
var (
|
|
// NewClient is a variable that holds the function to create a new GitHub client.
|
|
// This allows for mocking in tests.
|
|
NewClient = func(httpClient *http.Client) *github.Client {
|
|
return github.NewClient(httpClient)
|
|
}
|
|
// NewRequest is a variable that holds the function to create a new HTTP request.
|
|
NewRequest = func(method, url string, body io.Reader) (*http.Request, error) {
|
|
return http.NewRequest(method, url, body)
|
|
}
|
|
// DefaultClient is the default http client
|
|
DefaultClient = retry.NewClient(retry.NewTransport())
|
|
)
|
|
|
|
// GetLatestRelease gets the latest release for a repository.
|
|
func GetLatestRelease(owner, repo string) (*github.RepositoryRelease, error) {
|
|
client := NewClient(NewAuthenticatedClient(context.Background()))
|
|
release, _, err := client.Repositories.GetLatestRelease(context.Background(), owner, repo)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
return release, nil
|
|
}
|
|
|
|
// DownloadReleaseAsset downloads a release asset.
|
|
func DownloadReleaseAsset(asset *github.ReleaseAsset) ([]byte, error) {
|
|
req, err := NewRequest("GET", asset.GetBrowserDownloadURL(), nil)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
req.Header.Set("Accept", "application/octet-stream")
|
|
|
|
resp, err := DefaultClient.Do(req)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
defer resp.Body.Close()
|
|
|
|
if resp.StatusCode != http.StatusOK {
|
|
return nil, fmt.Errorf("bad status: %s", resp.Status)
|
|
}
|
|
|
|
buf := new(bytes.Buffer)
|
|
_, err = io.Copy(buf, resp.Body)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
return buf.Bytes(), nil
|
|
}
|
|
|
|
// ParseRepoFromURL parses the owner and repository from a GitHub URL.
|
|
func ParseRepoFromURL(u string) (owner, repo string, err error) {
|
|
u = strings.TrimSuffix(u, ".git")
|
|
|
|
prefixesToTrim := []string{
|
|
"https://github.com/",
|
|
"http://github.com/",
|
|
"git://github.com/",
|
|
"github.com/",
|
|
}
|
|
|
|
// Handle scp-like and other formats by replacing them first.
|
|
u = strings.Replace(u, "git@github.com:", "", 1)
|
|
u = strings.Replace(u, "git:github.com:", "", 1)
|
|
|
|
for _, p := range prefixesToTrim {
|
|
if strings.HasPrefix(u, p) {
|
|
u = strings.TrimPrefix(u, p)
|
|
break
|
|
}
|
|
}
|
|
|
|
parts := strings.Split(u, "/")
|
|
if len(parts) != 2 {
|
|
return "", "", fmt.Errorf("invalid or unsupported github url format: %s", u)
|
|
}
|
|
|
|
return parts[0], parts[1], nil
|
|
}
|