From 007457721069999b4838426baab0dd7e4e246be8 Mon Sep 17 00:00:00 2001 From: Claude Date: Thu, 2 Apr 2026 10:06:24 +0100 Subject: [PATCH] ax(node): rename pr to peerRegistry in worker_test.go AX-1 (Predictable Names): the local variable `pr` is an abbreviation that requires context to decode. Renamed to `peerRegistry` across all test functions so the type is self-evident at the point of use. Co-Authored-By: Charon --- pkg/node/worker_test.go | 40 ++++++++++++++++++++-------------------- 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/pkg/node/worker_test.go b/pkg/node/worker_test.go index 1977976..a7febdb 100644 --- a/pkg/node/worker_test.go +++ b/pkg/node/worker_test.go @@ -30,12 +30,12 @@ func TestWorker_NewWorker_Good(t *testing.T) { t.Fatalf("failed to generate identity: %v", err) } - pr, err := NewPeerRegistryWithPath(t.TempDir() + "/peers.json") + peerRegistry, err := NewPeerRegistryWithPath(t.TempDir() + "/peers.json") if err != nil { t.Fatalf("failed to create peer registry: %v", err) } - transport := NewTransport(nm, pr, DefaultTransportConfig()) + transport := NewTransport(nm, peerRegistry, DefaultTransportConfig()) worker := NewWorker(nm, transport) if worker == nil { @@ -61,12 +61,12 @@ func TestWorker_SetMinerManager_Good(t *testing.T) { t.Fatalf("failed to generate identity: %v", err) } - pr, err := NewPeerRegistryWithPath(t.TempDir() + "/peers.json") + peerRegistry, err := NewPeerRegistryWithPath(t.TempDir() + "/peers.json") if err != nil { t.Fatalf("failed to create peer registry: %v", err) } - transport := NewTransport(nm, pr, DefaultTransportConfig()) + transport := NewTransport(nm, peerRegistry, DefaultTransportConfig()) worker := NewWorker(nm, transport) mockManager := &mockMinerManager{} @@ -89,12 +89,12 @@ func TestWorker_SetProfileManager(t *testing.T) { t.Fatalf("failed to generate identity: %v", err) } - pr, err := NewPeerRegistryWithPath(t.TempDir() + "/peers.json") + peerRegistry, err := NewPeerRegistryWithPath(t.TempDir() + "/peers.json") if err != nil { t.Fatalf("failed to create peer registry: %v", err) } - transport := NewTransport(nm, pr, DefaultTransportConfig()) + transport := NewTransport(nm, peerRegistry, DefaultTransportConfig()) worker := NewWorker(nm, transport) mockProfile := &mockProfileManager{} @@ -117,12 +117,12 @@ func TestWorker_HandlePing(t *testing.T) { t.Fatalf("failed to generate identity: %v", err) } - pr, err := NewPeerRegistryWithPath(t.TempDir() + "/peers.json") + peerRegistry, err := NewPeerRegistryWithPath(t.TempDir() + "/peers.json") if err != nil { t.Fatalf("failed to create peer registry: %v", err) } - transport := NewTransport(nm, pr, DefaultTransportConfig()) + transport := NewTransport(nm, peerRegistry, DefaultTransportConfig()) worker := NewWorker(nm, transport) // Create a ping message @@ -176,12 +176,12 @@ func TestWorker_HandleGetStats(t *testing.T) { t.Fatalf("failed to generate identity: %v", err) } - pr, err := NewPeerRegistryWithPath(t.TempDir() + "/peers.json") + peerRegistry, err := NewPeerRegistryWithPath(t.TempDir() + "/peers.json") if err != nil { t.Fatalf("failed to create peer registry: %v", err) } - transport := NewTransport(nm, pr, DefaultTransportConfig()) + transport := NewTransport(nm, peerRegistry, DefaultTransportConfig()) worker := NewWorker(nm, transport) // Create a get_stats message @@ -234,12 +234,12 @@ func TestWorker_HandleStartMiner_NoManager(t *testing.T) { t.Fatalf("failed to generate identity: %v", err) } - pr, err := NewPeerRegistryWithPath(t.TempDir() + "/peers.json") + peerRegistry, err := NewPeerRegistryWithPath(t.TempDir() + "/peers.json") if err != nil { t.Fatalf("failed to create peer registry: %v", err) } - transport := NewTransport(nm, pr, DefaultTransportConfig()) + transport := NewTransport(nm, peerRegistry, DefaultTransportConfig()) worker := NewWorker(nm, transport) // Create a start_miner message @@ -272,12 +272,12 @@ func TestWorker_HandleStopMiner_NoManager(t *testing.T) { t.Fatalf("failed to generate identity: %v", err) } - pr, err := NewPeerRegistryWithPath(t.TempDir() + "/peers.json") + peerRegistry, err := NewPeerRegistryWithPath(t.TempDir() + "/peers.json") if err != nil { t.Fatalf("failed to create peer registry: %v", err) } - transport := NewTransport(nm, pr, DefaultTransportConfig()) + transport := NewTransport(nm, peerRegistry, DefaultTransportConfig()) worker := NewWorker(nm, transport) // Create a stop_miner message @@ -310,12 +310,12 @@ func TestWorker_HandleGetLogs_NoManager(t *testing.T) { t.Fatalf("failed to generate identity: %v", err) } - pr, err := NewPeerRegistryWithPath(t.TempDir() + "/peers.json") + peerRegistry, err := NewPeerRegistryWithPath(t.TempDir() + "/peers.json") if err != nil { t.Fatalf("failed to create peer registry: %v", err) } - transport := NewTransport(nm, pr, DefaultTransportConfig()) + transport := NewTransport(nm, peerRegistry, DefaultTransportConfig()) worker := NewWorker(nm, transport) // Create a get_logs message @@ -348,12 +348,12 @@ func TestWorker_HandleDeploy_Profile(t *testing.T) { t.Fatalf("failed to generate identity: %v", err) } - pr, err := NewPeerRegistryWithPath(t.TempDir() + "/peers.json") + peerRegistry, err := NewPeerRegistryWithPath(t.TempDir() + "/peers.json") if err != nil { t.Fatalf("failed to create peer registry: %v", err) } - transport := NewTransport(nm, pr, DefaultTransportConfig()) + transport := NewTransport(nm, peerRegistry, DefaultTransportConfig()) worker := NewWorker(nm, transport) // Create a deploy message for profile @@ -390,12 +390,12 @@ func TestWorker_HandleDeploy_UnknownType(t *testing.T) { t.Fatalf("failed to generate identity: %v", err) } - pr, err := NewPeerRegistryWithPath(t.TempDir() + "/peers.json") + peerRegistry, err := NewPeerRegistryWithPath(t.TempDir() + "/peers.json") if err != nil { t.Fatalf("failed to create peer registry: %v", err) } - transport := NewTransport(nm, pr, DefaultTransportConfig()) + transport := NewTransport(nm, peerRegistry, DefaultTransportConfig()) worker := NewWorker(nm, transport) // Create a deploy message with unknown type