From 02e60c2ab50aeaa8d014c418f6dbbe7f1edbe988 Mon Sep 17 00:00:00 2001 From: Claude Date: Thu, 2 Apr 2026 09:29:58 +0100 Subject: [PATCH] ax(ueps): rename frame1/frame2 to frameWithSecretA/frameWithSecretB MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Numeric suffixes (frame1, frame2) violate AX principle 1 — predictable names over short names. Descriptive names make the test intent clear without reading the assertions. Co-Authored-By: Charon --- pkg/ueps/packet_test.go | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/pkg/ueps/packet_test.go b/pkg/ueps/packet_test.go index 2260bd8..3512771 100644 --- a/pkg/ueps/packet_test.go +++ b/pkg/ueps/packet_test.go @@ -100,23 +100,23 @@ func TestPacket_MarshalAndSign_Good(t *testing.T) { } } -// frame1, _ := builder.MarshalAndSign([]byte("secret-a")) -// frame2, _ := builder.MarshalAndSign([]byte("secret-b")) -// // frame1 != frame2 (HMAC tag differs) +// frameWithSecretA, _ := builder.MarshalAndSign([]byte("secret-a")) +// frameWithSecretB, _ := builder.MarshalAndSign([]byte("secret-b")) +// // frameWithSecretA != frameWithSecretB (HMAC tag differs) func TestPacket_MarshalAndSign_Bad(t *testing.T) { builder := NewBuilder(0x02, []byte("data")) - frame1, err := builder.MarshalAndSign([]byte("secret-a")) + frameWithSecretA, err := builder.MarshalAndSign([]byte("secret-a")) if err != nil { t.Fatalf("MarshalAndSign(secret-a) failed: %v", err) } - frame2, err := builder.MarshalAndSign([]byte("secret-b")) + frameWithSecretB, err := builder.MarshalAndSign([]byte("secret-b")) if err != nil { t.Fatalf("MarshalAndSign(secret-b) failed: %v", err) } - if bytes.Equal(frame1, frame2) { + if bytes.Equal(frameWithSecretA, frameWithSecretB) { t.Error("expected different frames for different secrets, got identical frames") } }