From 1b021a073bad1e9818297bee5e1c45e84d71d134 Mon Sep 17 00:00:00 2001
From: Claude <developers@lethean.io>
Date: Thu, 2 Apr 2026 16:50:13 +0100
Subject: [PATCH] ax(node): rename ack to acknowledgement in Worker message
 handlers
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

AX-1: predictable names over short names. The variable `ack` is an
abbreviation for `acknowledgement` — renamed in all six callsites
within handleStartMiner, handleStopMiner, and handleDeploy so the
name is self-describing without a comment.

Co-Authored-By: Charon <charon@lethean.io>
---
 pkg/node/worker.go | 26 +++++++++++++-------------
 1 file changed, 13 insertions(+), 13 deletions(-)

diff --git a/pkg/node/worker.go b/pkg/node/worker.go
index 50ddf0d..f5f85b8 100644
--- a/pkg/node/worker.go
+++ b/pkg/node/worker.go
@@ -234,18 +234,18 @@ func (worker *Worker) handleStartMiner(msg *Message) (*Message, error) {
 	// Start the miner
 	miner, err := worker.minerManager.StartMiner(payload.MinerType, config)
 	if err != nil {
-		ack := MinerAckPayload{
+		acknowledgement := MinerAckPayload{
 			Success: false,
 			Error:   err.Error(),
 		}
-		return msg.Reply(MsgMinerAck, ack)
+		return msg.Reply(MsgMinerAck, acknowledgement)
 	}
 
-	ack := MinerAckPayload{
+	acknowledgement := MinerAckPayload{
 		Success:   true,
 		MinerName: miner.GetName(),
 	}
-	return msg.Reply(MsgMinerAck, ack)
+	return msg.Reply(MsgMinerAck, acknowledgement)
 }
 
 // response, err := worker.handleStopMiner(message)
@@ -260,15 +260,15 @@ func (worker *Worker) handleStopMiner(msg *Message) (*Message, error) {
 	}
 
 	err := worker.minerManager.StopMiner(payload.MinerName)
-	ack := MinerAckPayload{
+	acknowledgement := MinerAckPayload{
 		Success:   err == nil,
 		MinerName: payload.MinerName,
 	}
 	if err != nil {
-		ack.Error = err.Error()
+		acknowledgement.Error = err.Error()
 	}
 
-	return msg.Reply(MsgMinerAck, ack)
+	return msg.Reply(MsgMinerAck, acknowledgement)
 }
 
 // response, err := worker.handleGetLogs(message)
@@ -344,19 +344,19 @@ func (worker *Worker) handleDeploy(conn *PeerConnection, msg *Message) (*Message
 		}
 
 		if err := worker.profileManager.SaveProfile(profile); err != nil {
-			ack := DeployAckPayload{
+			acknowledgement := DeployAckPayload{
 				Success: false,
 				Name:    payload.Name,
 				Error:   err.Error(),
 			}
-			return msg.Reply(MsgDeployAck, ack)
+			return msg.Reply(MsgDeployAck, acknowledgement)
 		}
 
-		ack := DeployAckPayload{
+		acknowledgement := DeployAckPayload{
 			Success: true,
 			Name:    payload.Name,
 		}
-		return msg.Reply(MsgDeployAck, ack)
+		return msg.Reply(MsgDeployAck, acknowledgement)
 
 	case BundleMiner, BundleFull:
 		// Determine installation directory
@@ -389,7 +389,7 @@ func (worker *Worker) handleDeploy(conn *PeerConnection, msg *Message) (*Message
 		}
 
 		// Success response
-		ack := DeployAckPayload{
+		acknowledgement := DeployAckPayload{
 			Success: true,
 			Name:    payload.Name,
 		}
@@ -400,7 +400,7 @@ func (worker *Worker) handleDeploy(conn *PeerConnection, msg *Message) (*Message
 			"miner_path": minerPath,
 		})
 
-		return msg.Reply(MsgDeployAck, ack)
+		return msg.Reply(MsgDeployAck, acknowledgement)
 
 	default:
 		return nil, &ProtocolError{Code: ErrCodeInvalidMessage, Message: "unknown bundle type: " + payload.BundleType}