From 3153a44a4bec9233c0f7caa7a64dbbf8026e4515 Mon Sep 17 00:00:00 2001 From: Claude Date: Thu, 2 Apr 2026 10:45:25 +0100 Subject: [PATCH] =?UTF-8?q?ax(ueps):=20rename=20writeTLV=20params=20tag?= =?UTF-8?q?=E2=86=92tagByte,=20value=E2=86=92tagValue?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit AX Principle 1: predictable names over short names. Parameters named `tag` and `value` lack context; `tagByte` and `tagValue` are self-documenting and consistent with the naming used in reader.go. Co-Authored-By: Charon --- pkg/ueps/packet.go | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/pkg/ueps/packet.go b/pkg/ueps/packet.go index e45c433..840f15d 100644 --- a/pkg/ueps/packet.go +++ b/pkg/ueps/packet.go @@ -104,19 +104,19 @@ func (builder *PacketBuilder) MarshalAndSign(sharedSecret []byte) ([]byte, error // writeTLV(buffer, TagVersion, []byte{0x09}) // writeTLV(buffer, TagIntent, []byte{intentID}) -func writeTLV(writer io.Writer, tag uint8, value []byte) error { - // writeTLV(writer, tag, bytes.Repeat([]byte("x"), 256)) → errTLVValueTooLarge - if len(value) > 255 { +func writeTLV(writer io.Writer, tagByte uint8, tagValue []byte) error { + // writeTLV(writer, TagVersion, bytes.Repeat([]byte("x"), 256)) → errTLVValueTooLarge + if len(tagValue) > 255 { return errTLVValueTooLarge } - if _, err := writer.Write([]byte{tag}); err != nil { + if _, err := writer.Write([]byte{tagByte}); err != nil { return err } - if _, err := writer.Write([]byte{uint8(len(value))}); err != nil { + if _, err := writer.Write([]byte{uint8(len(tagValue))}); err != nil { return err } - if _, err := writer.Write(value); err != nil { + if _, err := writer.Write(tagValue); err != nil { return err } return nil