From 35342e234987ebf2e4e74e114e265344fbe58413 Mon Sep 17 00:00:00 2001 From: Claude Date: Thu, 2 Apr 2026 14:07:29 +0100 Subject: [PATCH] ax(ueps): align comment examples with predictable variable names MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Use sharedSecret in doc-comment examples to match actual test body variable names — resolves AX principle 1+2 violation where comment examples used the abbreviated form secret while code used sharedSecret. Co-Authored-By: Charon --- pkg/ueps/reader_test.go | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/pkg/ueps/reader_test.go b/pkg/ueps/reader_test.go index 6363f23..c5b6e43 100644 --- a/pkg/ueps/reader_test.go +++ b/pkg/ueps/reader_test.go @@ -6,8 +6,8 @@ import ( "testing" ) -// builder := NewPacketBuilder(0x01, []byte("hello")); frame, _ := builder.MarshalAndSign(secret) -// packet, err := ReadAndVerify(bufio.NewReader(bytes.NewReader(frame)), secret) +// builder := NewPacketBuilder(0x01, []byte("hello")); frame, _ := builder.MarshalAndSign(sharedSecret) +// packet, err := ReadAndVerify(bufio.NewReader(bytes.NewReader(frame)), sharedSecret) // packet.Header.IntentID == 0x01; packet.Payload == []byte("hello") func TestReader_ReadAndVerify_Good(t *testing.T) { sharedSecret := []byte("test-shared-secret") @@ -40,9 +40,9 @@ func TestReader_ReadAndVerify_Good(t *testing.T) { } } -// frame, _ := NewPacketBuilder(0x02, []byte("sensitive data")).MarshalAndSign(secret) +// frame, _ := NewPacketBuilder(0x02, []byte("sensitive data")).MarshalAndSign(sharedSecret) // corrupted := append([]byte(nil), frame...); corrupted[len(corrupted)-1] ^= 0xFF -// packet, err := ReadAndVerify(bufio.NewReader(bytes.NewReader(corrupted)), secret) +// packet, err := ReadAndVerify(bufio.NewReader(bytes.NewReader(corrupted)), sharedSecret) // err == errIntegrityViolation (HMAC mismatch on tampered payload) func TestReader_ReadAndVerify_Bad(t *testing.T) { sharedSecret := []byte("test-shared-secret") @@ -72,7 +72,7 @@ func TestReader_ReadAndVerify_Bad(t *testing.T) { } // frameWithoutHMAC := []byte{TagVersion, 0x01, 0x09, TagPayload, 'x'} -// packet, err := ReadAndVerify(bufio.NewReader(bytes.NewReader(frameWithoutHMAC)), secret) +// packet, err := ReadAndVerify(bufio.NewReader(bytes.NewReader(frameWithoutHMAC)), sharedSecret) // err == errMissingHMAC (no 0x06 HMAC tag present in stream) func TestReader_ReadAndVerify_Ugly(t *testing.T) { frameWithoutHMAC := []byte{