From 3a690ee485d0f7da0c05ce8e5a3a292e4b2ec8d7 Mon Sep 17 00:00:00 2001 From: Claude Date: Thu, 2 Apr 2026 11:21:55 +0100 Subject: [PATCH] ax(node): rename nm to manager in NewNodeManagerWithPaths for predictable naming MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit AX Principle 1 — nm abbreviates NodeManager, requiring mapping overhead. Rename to manager and update the NewNodeManager usage-example comment to match. Co-Authored-By: Charon --- pkg/node/identity.go | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/pkg/node/identity.go b/pkg/node/identity.go index 0c3e0cb..b37cbc4 100644 --- a/pkg/node/identity.go +++ b/pkg/node/identity.go @@ -79,9 +79,9 @@ type NodeManager struct { mutex sync.RWMutex } -// nm, err := node.NewNodeManager() +// nodeManager, err := node.NewNodeManager() // if err != nil { return err } -// if !nm.HasIdentity() { nm.GenerateIdentity("my-node", RoleDual) } +// if !nodeManager.HasIdentity() { nodeManager.GenerateIdentity("my-node", RoleDual) } func NewNodeManager() (*NodeManager, error) { keyPath, err := xdg.DataFile("lethean-desktop/node/private.key") if err != nil { @@ -99,18 +99,18 @@ func NewNodeManager() (*NodeManager, error) { // NewNodeManagerWithPaths creates a NodeManager with custom paths. // This is primarily useful for testing to avoid xdg path caching issues. func NewNodeManagerWithPaths(keyPath, configPath string) (*NodeManager, error) { - nm := &NodeManager{ + manager := &NodeManager{ keyPath: keyPath, configPath: configPath, } // Try to load existing identity - if err := nm.loadIdentity(); err != nil { + if err := manager.loadIdentity(); err != nil { // Identity doesn't exist yet, that's ok - return nm, nil + return manager, nil } - return nm, nil + return manager, nil } // if nm.HasIdentity() { return nm.GetIdentity() }