Snider/Mining
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

ax(ueps): fix writeTLV comment to match actual parameter name

Browse source 
Comment examples used 'buffer' but the parameter is named 'writer' —
the example was not a valid call site. AX Principle 2 requires comments
to show concrete, accurate usage with real values.

Co-Authored-By: Charon <charon@lethean.io>
This commit is contained in:
Claude 2026-04-02 13:38:31 +01:00
parent af7070f27a
commit 45da2e4e88
No known key found for this signature in database
GPG key ID: AF404715446AEB41
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
pkg/ueps/packet.go
View file

@ -103,8 +103,8 @@ func (builder *PacketBuilder) MarshalAndSign(sharedSecret []byte) ([]byte, error
return frameBuffer.Bytes(), nil
}
// if err := writeTLV(buffer, TagVersion, []byte{0x09}); err != nil { return nil, err }
// if err := writeTLV(buffer, TagIntent, []byte{0x01}); err != nil { return nil, err }
// if err := writeTLV(writer, TagVersion, []byte{0x09}); err != nil { return nil, err }
// if err := writeTLV(writer, TagIntent, []byte{0x01}); err != nil { return nil, err }
func writeTLV(writer io.Writer, tagType uint8, tagValue []byte) error {
// writeTLV(writer, TagVersion, bytes.Repeat([]byte("x"), 256)) → errTLVValueTooLarge
if len(tagValue) > 255 {