From 5a6da79311809ff85dd1d45b9bef62aa0ac5fb2c Mon Sep 17 00:00:00 2001 From: Claude Date: Thu, 2 Apr 2026 07:35:52 +0100 Subject: [PATCH] ax(mining): rename minerCfg loop variable to autostartEntry `minerCfg` is an abbreviated name for `MinerAutostartConfig` loop variables. Renamed to `autostartEntry` across three range loops in manager.go for AX Principle 1 compliance (predictable names over short names). Co-Authored-By: Charon --- pkg/mining/manager.go | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/pkg/mining/manager.go b/pkg/mining/manager.go index 4828c1e..24c0fbe 100644 --- a/pkg/mining/manager.go +++ b/pkg/mining/manager.go @@ -202,11 +202,11 @@ func (m *Manager) autostartMiners() { return } - for _, minerCfg := range cfg.Miners { - if minerCfg.Autostart && minerCfg.Config != nil { - logging.Info("autostarting miner", logging.Fields{"type": minerCfg.MinerType}) - if _, err := m.StartMiner(context.Background(), minerCfg.MinerType, minerCfg.Config); err != nil { - logging.Error("failed to autostart miner", logging.Fields{"type": minerCfg.MinerType, "error": err}) + for _, autostartEntry := range cfg.Miners { + if autostartEntry.Autostart && autostartEntry.Config != nil { + logging.Info("autostarting miner", logging.Fields{"type": autostartEntry.MinerType}) + if _, err := m.StartMiner(context.Background(), autostartEntry.MinerType, autostartEntry.Config); err != nil { + logging.Error("failed to autostart miner", logging.Fields{"type": autostartEntry.MinerType, "error": err}) } } } @@ -369,9 +369,9 @@ func (m *Manager) UninstallMiner(ctx context.Context, minerType string) error { return UpdateMinersConfig(func(cfg *MinersConfig) error { var updatedMiners []MinerAutostartConfig - for _, minerCfg := range cfg.Miners { - if !strings.EqualFold(minerCfg.MinerType, minerType) { - updatedMiners = append(updatedMiners, minerCfg) + for _, autostartEntry := range cfg.Miners { + if !strings.EqualFold(autostartEntry.MinerType, minerType) { + updatedMiners = append(updatedMiners, autostartEntry) } } cfg.Miners = updatedMiners @@ -383,8 +383,8 @@ func (m *Manager) UninstallMiner(ctx context.Context, minerType string) error { func (m *Manager) updateMinerConfig(minerType string, autostart bool, config *Config) error { return UpdateMinersConfig(func(cfg *MinersConfig) error { found := false - for i, minerCfg := range cfg.Miners { - if strings.EqualFold(minerCfg.MinerType, minerType) { + for i, autostartEntry := range cfg.Miners { + if strings.EqualFold(autostartEntry.MinerType, minerType) { cfg.Miners[i].Autostart = autostart cfg.Miners[i].Config = config found = true