From 64d11df4627367d2d98e2ced2319ff80c03aa521 Mon Sep 17 00:00:00 2001 From: Claude Date: Thu, 2 Apr 2026 07:52:05 +0100 Subject: [PATCH] ax(mining): rename mgr to concreteManager (AX Principle 1) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit mgr is an abbreviated variable name. AX Principle 1 requires predictable names over short names — names should not require a comment to explain. Co-Authored-By: Charon --- pkg/mining/container.go | 8 ++++---- pkg/mining/service.go | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/pkg/mining/container.go b/pkg/mining/container.go index 21ff380..fdde0f6 100644 --- a/pkg/mining/container.go +++ b/pkg/mining/container.go @@ -118,8 +118,8 @@ func (c *Container) Initialize(ctx context.Context) error { c.eventHub = NewEventHub() // Wire up event hub to manager - if mgr, ok := c.manager.(*Manager); ok { - mgr.SetEventHub(c.eventHub) + if concreteManager, ok := c.manager.(*Manager); ok { + concreteManager.SetEventHub(c.eventHub) } c.initialized = true @@ -184,8 +184,8 @@ func (c *Container) Shutdown(ctx context.Context) error { } // 4. Stop miner manager - if mgr, ok := c.manager.(*Manager); ok { - mgr.Stop() + if concreteManager, ok := c.manager.(*Manager); ok { + concreteManager.Stop() } // 5. Close database diff --git a/pkg/mining/service.go b/pkg/mining/service.go index 747ab26..7389d47 100644 --- a/pkg/mining/service.go +++ b/pkg/mining/service.go @@ -428,8 +428,8 @@ func NewService(manager ManagerInterface, listenAddr string, displayAddr string, go eventHub.Run() // Wire up event hub to manager for miner events - if mgr, ok := manager.(*Manager); ok { - mgr.SetEventHub(eventHub) + if concreteManager, ok := manager.(*Manager); ok { + concreteManager.SetEventHub(eventHub) } // Set up state provider for WebSocket state sync on reconnect