Snider/Mining
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

ax(ueps): include method name in sentinelError test names
Some checks are pending
Security Scan / security (push) Waiting to run
Details
Test / test (push) Waiting to run
Details

Browse source 
TestFilename_Function_{Good,Bad,Ugly} requires the function being
tested, not just the type name. sentinelError tests exercise the
.Error() method so names must be TestPacket_sentinelError_Error_*.

Co-Authored-By: Charon <charon@lethean.io>
This commit is contained in:
Claude 2026-04-02 14:02:58 +01:00
parent 0fe74ae8a6
commit 6df2566acb
No known key found for this signature in database
GPG key ID: AF404715446AEB41
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
pkg/ueps/packet_test.go
View file

@ -208,7 +208,7 @@ func TestPacket_writeTLV_Ugly(t *testing.T) {
}
// var sentinel sentinelError = "record not found"; sentinel.Error() == "record not found"
func TestPacket_sentinelError_Good(t *testing.T) {
func TestPacket_sentinelError_Error_Good(t *testing.T) {
sentinel := sentinelError("record not found")
if sentinel.Error() != "record not found" {
@ -217,7 +217,7 @@ func TestPacket_sentinelError_Good(t *testing.T) {
}
// var sentinel sentinelError = ""; sentinel.Error() == "" (empty message is valid sentinel)
func TestPacket_sentinelError_Bad(t *testing.T) {
func TestPacket_sentinelError_Error_Bad(t *testing.T) {
sentinel := sentinelError("")
if sentinel.Error() != "" {
@ -226,7 +226,7 @@ func TestPacket_sentinelError_Bad(t *testing.T) {
}
// var sentinelFirst, sentinelSecond sentinelError = "x", "x"; sentinelFirst == sentinelSecond (sentinel identity: same message = same error)
func TestPacket_sentinelError_Ugly(t *testing.T) {
func TestPacket_sentinelError_Error_Ugly(t *testing.T) {
sentinelFirst := sentinelError("integrity violation")
sentinelSecond := sentinelError("integrity violation")