From 74ebda333d565eff26a04d3451e7c9731d580bd9 Mon Sep 17 00:00:00 2001 From: Claude Date: Thu, 2 Apr 2026 14:19:36 +0100 Subject: [PATCH] ax(mining): rename mu to mutex in SettingsManager MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit AX Principle 1 — predictable names over short names. The mu field requires context to understand; mutex is self-describing. Co-Authored-By: Charon --- pkg/mining/settings_manager.go | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/pkg/mining/settings_manager.go b/pkg/mining/settings_manager.go index 02c7b94..61ea09d 100644 --- a/pkg/mining/settings_manager.go +++ b/pkg/mining/settings_manager.go @@ -91,7 +91,7 @@ func DefaultSettings() *AppSettings { // settingsManager, err := NewSettingsManager() // settings := settingsManager.Get() type SettingsManager struct { - mu sync.RWMutex + mutex sync.RWMutex settings *AppSettings settingsPath string } @@ -125,8 +125,8 @@ func NewSettingsManager() (*SettingsManager, error) { // if err := settingsManager.Load(); err != nil && !os.IsNotExist(err) { return err } func (settingsManager *SettingsManager) Load() error { - settingsManager.mu.Lock() - defer settingsManager.mu.Unlock() + settingsManager.mutex.Lock() + defer settingsManager.mutex.Unlock() data, err := os.ReadFile(settingsManager.settingsPath) if err != nil { @@ -144,8 +144,8 @@ func (settingsManager *SettingsManager) Load() error { // if err := settingsManager.Save(); err != nil { return err } func (settingsManager *SettingsManager) Save() error { - settingsManager.mu.Lock() - defer settingsManager.mu.Unlock() + settingsManager.mutex.Lock() + defer settingsManager.mutex.Unlock() data, err := json.MarshalIndent(settingsManager.settings, "", " ") if err != nil { @@ -158,8 +158,8 @@ func (settingsManager *SettingsManager) Save() error { // settings := settingsManager.Get() // if settings.Theme == "dark" { ... } func (settingsManager *SettingsManager) Get() *AppSettings { - settingsManager.mu.RLock() - defer settingsManager.mu.RUnlock() + settingsManager.mutex.RLock() + defer settingsManager.mutex.RUnlock() // Return a copy to prevent concurrent modification settingsCopy := *settingsManager.settings @@ -168,8 +168,8 @@ func (settingsManager *SettingsManager) Get() *AppSettings { // settingsManager.Update(func(s *AppSettings) { s.Theme = "dark" }) func (settingsManager *SettingsManager) Update(fn func(*AppSettings)) error { - settingsManager.mu.Lock() - defer settingsManager.mu.Unlock() + settingsManager.mutex.Lock() + defer settingsManager.mutex.Unlock() fn(settingsManager.settings) @@ -195,8 +195,8 @@ func (settingsManager *SettingsManager) UpdateWindowState(x, y, width, height in // state := settingsManager.GetWindowState() // if state.Maximized { ... } func (settingsManager *SettingsManager) GetWindowState() WindowState { - settingsManager.mu.RLock() - defer settingsManager.mu.RUnlock() + settingsManager.mutex.RLock() + defer settingsManager.mutex.RUnlock() return settingsManager.settings.Window }