Snider/Mining
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

ax(node): rename abbreviated receiver names to full predictable names
Some checks are pending
Security Scan / security (push) Waiting to run
Details
Test / test (push) Waiting to run
Details

Browse source 
Replace single-letter receivers (m *Message, e *ProtocolError) and
parameter (v interface{}) with full names (message, protocolError, target)
per AX Principle 1: predictable names over short names.

Co-Authored-By: Charon <charon@lethean.io>
This commit is contained in:
Claude 2026-04-02 14:22:52 +01:00
parent 8b22e9dda6
commit 906b2c9456
No known key found for this signature in database
GPG key ID: AF404715446AEB41
2 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
pkg/node/message.go
View file

@ -95,22 +95,22 @@ func NewMessage(msgType MessageType, from, to string, payload interface{}) (*Mes
// resp, err := msg.Reply(MsgPong, PongPayload{SentAt: ping.SentAt, ReceivedAt: time.Now().UnixMilli()})
// if err != nil { return nil, err }
func (m *Message) Reply(msgType MessageType, payload interface{}) (*Message, error) {
reply, err := NewMessage(msgType, m.To, m.From, payload)
func (message *Message) Reply(msgType MessageType, payload interface{}) (*Message, error) {
reply, err := NewMessage(msgType, message.To, message.From, payload)
if err != nil {
return nil, err
}
reply.ReplyTo = m.ID
reply.ReplyTo = message.ID
return reply, nil
}
// var ping PingPayload
// if err := msg.ParsePayload(&ping); err != nil { return nil, err }
func (m *Message) ParsePayload(v interface{}) error {
if m.Payload == nil {
func (message *Message) ParsePayload(target interface{}) error {
if message.Payload == nil {
return nil
}
return json.Unmarshal(m.Payload, v)
return json.Unmarshal(message.Payload, target)
}
// --- Payload Types ---

4
pkg/node/protocol.go
View file

@ -10,8 +10,8 @@ type ProtocolError struct {
Message string
}
func (e *ProtocolError) Error() string {
return "remote error (" + strconv.Itoa(e.Code) + "): " + e.Message
func (protocolError *ProtocolError) Error() string {
return "remote error (" + strconv.Itoa(protocolError.Code) + "): " + protocolError.Message
}
// handler := &ResponseHandler{}