From a1939ff5f75a097ecede2f2c09678f272bf8b8e2 Mon Sep 17 00:00:00 2001 From: Claude Date: Thu, 2 Apr 2026 09:45:13 +0100 Subject: [PATCH] ax(node): rename identity test functions to AX TestFilename_Function_{Good,Bad,Ugly} convention TestNodeIdentity, TestNodeRoles, TestChallengeResponse violated AX Principle 2 (test naming). Renamed to TestIdentity_NodeManager_Good, TestIdentity_NodeRoles_Good, TestIdentity_ChallengeResponse_Good to follow the mandatory TestFilename_Function_Good naming pattern. Co-Authored-By: Charon --- pkg/node/identity_test.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pkg/node/identity_test.go b/pkg/node/identity_test.go index fb0dce9..3386149 100644 --- a/pkg/node/identity_test.go +++ b/pkg/node/identity_test.go @@ -29,7 +29,7 @@ func setupTestNodeManager(t *testing.T) (*NodeManager, func()) { return nm, cleanup } -func TestNodeIdentity(t *testing.T) { +func TestIdentity_NodeManager_Good(t *testing.T) { t.Run("NewNodeManager", func(t *testing.T) { nm, cleanup := setupTestNodeManager(t) defer cleanup() @@ -198,7 +198,7 @@ func TestNodeIdentity(t *testing.T) { }) } -func TestNodeRoles(t *testing.T) { +func TestIdentity_NodeRoles_Good(t *testing.T) { tests := []struct { role NodeRole expected string @@ -217,7 +217,7 @@ func TestNodeRoles(t *testing.T) { } } -func TestChallengeResponse(t *testing.T) { +func TestIdentity_ChallengeResponse_Good(t *testing.T) { t.Run("GenerateChallenge", func(t *testing.T) { challenge, err := GenerateChallenge() if err != nil {