From a8b2dad8ec5490cdfd34e2a7fd650059dbe04f54 Mon Sep 17 00:00:00 2001 From: Claude Date: Thu, 2 Apr 2026 10:52:23 +0100 Subject: [PATCH] ax(ueps): rename tagByte to tagType in writeTLV for semantic clarity tagByte described the storage representation; tagType names the semantic role (the T in TLV = Type-Length-Value), matching AX Principle 1. Co-Authored-By: Charon --- pkg/ueps/packet.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/ueps/packet.go b/pkg/ueps/packet.go index f0a615a..251150a 100644 --- a/pkg/ueps/packet.go +++ b/pkg/ueps/packet.go @@ -104,13 +104,13 @@ func (builder *PacketBuilder) MarshalAndSign(sharedSecret []byte) ([]byte, error // writeTLV(buffer, TagVersion, []byte{0x09}) // writeTLV(buffer, TagIntent, []byte{intentID}) -func writeTLV(writer io.Writer, tagByte uint8, tagValue []byte) error { +func writeTLV(writer io.Writer, tagType uint8, tagValue []byte) error { // writeTLV(writer, TagVersion, bytes.Repeat([]byte("x"), 256)) → errTLVValueTooLarge if len(tagValue) > 255 { return errTLVValueTooLarge } - if _, err := writer.Write([]byte{tagByte}); err != nil { + if _, err := writer.Write([]byte{tagType}); err != nil { return err } if _, err := writer.Write([]byte{uint8(len(tagValue))}); err != nil {