Snider/Mining
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

ax(node): rename receiver h to handler in ResponseHandler (AX Principle 1)

Browse source 
Single-letter receiver `h` requires mental mapping to understand it refers to
*ResponseHandler. Renamed to `handler` for self-documenting, predictable naming.

Co-Authored-By: Charon <charon@lethean.io>
This commit is contained in:
Claude 2026-04-02 13:33:02 +01:00
parent d65a1995be
commit aa36675cfb
No known key found for this signature in database
GPG key ID: AF404715446AEB41
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
pkg/node/protocol.go
View file

@ -19,7 +19,7 @@ func (e *ProtocolError) Error() string {
type ResponseHandler struct{}
// if err := handler.ValidateResponse(resp, MsgPong); err != nil { return 0, err }
func (h *ResponseHandler) ValidateResponse(resp *Message, expectedType MessageType) error {
func (handler *ResponseHandler) ValidateResponse(resp *Message, expectedType MessageType) error {
if resp == nil {
return &ProtocolError{Code: ErrCodeUnknown, Message: "nil response"}
}
@ -43,8 +43,8 @@ func (h *ResponseHandler) ValidateResponse(resp *Message, expectedType MessageTy
// var stats StatsPayload
// if err := handler.ParseResponse(resp, MsgStats, &stats); err != nil { return nil, err }
func (h *ResponseHandler) ParseResponse(resp *Message, expectedType MessageType, target interface{}) error {
if err := h.ValidateResponse(resp, expectedType); err != nil {
func (handler *ResponseHandler) ParseResponse(resp *Message, expectedType MessageType, target interface{}) error {
if err := handler.ValidateResponse(resp, expectedType); err != nil {
return err
}