Snider/Mining
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

ax(node): expand nm abbreviation to nodeManager in usage comments
Some checks are pending
Security Scan / security (push) Waiting to run
Details
Test / test (push) Waiting to run
Details

Browse source 
AX Principle 1: predictable names over short names. The `nm` shorthand
in seven comment examples was inconsistent with the full `nodeManager`
name used in actual call-site code and the `manager` receiver name
throughout the file.

Co-Authored-By: Charon <charon@lethean.io>
This commit is contained in:
Claude 2026-04-02 16:51:54 +01:00
parent f78be454e4
commit b4cef1305e
No known key found for this signature in database
GPG key ID: AF404715446AEB41
1 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
pkg/node/identity.go
View file

@ -49,9 +49,9 @@ func VerifyChallenge(challenge, response, sharedSecret []byte) bool {
return hmac.Equal(response, expected)
}
// nm.GenerateIdentity("my-worker", RoleWorker)
// nm.GenerateIdentity("controller-1", RoleController)
// nm.GenerateIdentity("fleet-node", RoleDual)
// nodeManager.GenerateIdentity("my-worker", RoleWorker)
// nodeManager.GenerateIdentity("controller-1", RoleController)
// nodeManager.GenerateIdentity("fleet-node", RoleDual)
type NodeRole string
const (
@ -119,14 +119,14 @@ func NewNodeManagerWithPaths(keyPath, configPath string) (*NodeManager, error) {
return manager, nil
}
// if nm.HasIdentity() { return nm.GetIdentity() }
// if nodeManager.HasIdentity() { return nodeManager.GetIdentity() }
func (manager *NodeManager) HasIdentity() bool {
manager.mutex.RLock()
defer manager.mutex.RUnlock()
return manager.identity != nil
}
// identity := nm.GetIdentity()
// identity := nodeManager.GetIdentity()
// if identity == nil { return core.E("node", "identity not initialised", nil) }
func (manager *NodeManager) GetIdentity() *NodeIdentity {
manager.mutex.RLock()
@ -139,7 +139,7 @@ func (manager *NodeManager) GetIdentity() *NodeIdentity {
return &identity
}
// if err := nm.GenerateIdentity("my-worker", RoleWorker); err != nil { return err }
// if err := nodeManager.GenerateIdentity("my-worker", RoleWorker); err != nil { return err }
func (manager *NodeManager) GenerateIdentity(name string, role NodeRole) error {
manager.mutex.Lock()
defer manager.mutex.Unlock()
@ -179,7 +179,7 @@ func (manager *NodeManager) GenerateIdentity(name string, role NodeRole) error {
return nil
}
// secret, err := nm.DeriveSharedSecret(peer.PublicKey)
// secret, err := nodeManager.DeriveSharedSecret(peer.PublicKey)
// smsg.Encrypt(msg, base64.StdEncoding.EncodeToString(secret))
func (manager *NodeManager) DeriveSharedSecret(peerPubKeyBase64 string) ([]byte, error) {
manager.mutex.RLock()