ax(node): rename abbreviated mu/wg to resultsMutex/waitGroup in GetAllStats
AX Principle 1 — predictable names over short names. `mu` and `wg` require mental mapping; `resultsMutex` and `waitGroup` state their purpose directly. Co-Authored-By: Charon <charon@lethean.io>
This commit is contained in:
parent
8a4010f4a5
commit
c0856259cd
1 changed files with 7 additions and 7 deletions
|
|
@ -242,13 +242,13 @@ func (c *Controller) GetRemoteLogs(peerID, minerName string, lines int) ([]strin
|
|||
func (c *Controller) GetAllStats() map[string]*StatsPayload {
|
||||
peers := c.peers.GetConnectedPeers()
|
||||
results := make(map[string]*StatsPayload)
|
||||
var mu sync.Mutex
|
||||
var wg sync.WaitGroup
|
||||
var resultsMutex sync.Mutex
|
||||
var waitGroup sync.WaitGroup
|
||||
|
||||
for _, peer := range peers {
|
||||
wg.Add(1)
|
||||
waitGroup.Add(1)
|
||||
go func(p *Peer) {
|
||||
defer wg.Done()
|
||||
defer waitGroup.Done()
|
||||
stats, err := c.GetRemoteStats(p.ID)
|
||||
if err != nil {
|
||||
logging.Debug("failed to get stats from peer", logging.Fields{
|
||||
|
|
@ -258,13 +258,13 @@ func (c *Controller) GetAllStats() map[string]*StatsPayload {
|
|||
})
|
||||
return // Skip failed peers
|
||||
}
|
||||
mu.Lock()
|
||||
resultsMutex.Lock()
|
||||
results[p.ID] = stats
|
||||
mu.Unlock()
|
||||
resultsMutex.Unlock()
|
||||
}(peer)
|
||||
}
|
||||
|
||||
wg.Wait()
|
||||
waitGroup.Wait()
|
||||
return results
|
||||
}
|
||||
|
||||
|
|
|
|||
Loading…
Add table
Reference in a new issue