From c85217dfca600fabdbc3ebc77315c9194c042ac8 Mon Sep 17 00:00:00 2001 From: Claude Date: Thu, 2 Apr 2026 07:41:15 +0100 Subject: [PATCH] ax(node): rename rtt to roundTripTime in PingPeer MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit AX Principle #1: names must not require a comment to explain. The comment "Calculate round-trip time" existed solely to decode the abbreviation rtt — proof the name was too short. Co-Authored-By: Charon --- pkg/node/controller.go | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/pkg/node/controller.go b/pkg/node/controller.go index 37bcb41..d1eeef8 100644 --- a/pkg/node/controller.go +++ b/pkg/node/controller.go @@ -294,16 +294,15 @@ func (c *Controller) PingPeer(peerID string) (float64, error) { return 0, err } - // Calculate round-trip time - rtt := time.Since(sentAt).Seconds() * 1000 // Convert to ms + roundTripTime := time.Since(sentAt).Seconds() * 1000 // milliseconds // Update peer metrics peer := c.peers.GetPeer(peerID) if peer != nil { - c.peers.UpdateMetrics(peerID, rtt, peer.GeoKM, peer.Hops) + c.peers.UpdateMetrics(peerID, roundTripTime, peer.GeoKM, peer.Hops) } - return rtt, nil + return roundTripTime, nil } // ConnectToPeer establishes a connection to a peer.