From caa887325dde823bb2fcd43b0fdab84b2a39e250 Mon Sep 17 00:00:00 2001
From: Claude <developers@lethean.io>
Date: Thu, 2 Apr 2026 08:47:09 +0100
Subject: [PATCH] ax(mining): rename cfg to configuration in
 circuit_breaker_test.go
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

AX Principle 1 — predictable names over short names. `cfg` requires
context to decode; `configuration` is self-describing.

Co-Authored-By: Charon <charon@lethean.io>
---
 pkg/mining/circuit_breaker_test.go | 38 +++++++++++++++---------------
 1 file changed, 19 insertions(+), 19 deletions(-)

diff --git a/pkg/mining/circuit_breaker_test.go b/pkg/mining/circuit_breaker_test.go
index 03363b0..b0e5d4a 100644
--- a/pkg/mining/circuit_breaker_test.go
+++ b/pkg/mining/circuit_breaker_test.go
@@ -8,16 +8,16 @@ import (
 )
 
 func TestCircuitBreakerDefaultConfig(t *testing.T) {
-	cfg := DefaultCircuitBreakerConfig()
+	configuration := DefaultCircuitBreakerConfig()
 
-	if cfg.FailureThreshold != 3 {
-		t.Errorf("expected FailureThreshold 3, got %d", cfg.FailureThreshold)
+	if configuration.FailureThreshold != 3 {
+		t.Errorf("expected FailureThreshold 3, got %d", configuration.FailureThreshold)
 	}
-	if cfg.ResetTimeout != 30*time.Second {
-		t.Errorf("expected ResetTimeout 30s, got %v", cfg.ResetTimeout)
+	if configuration.ResetTimeout != 30*time.Second {
+		t.Errorf("expected ResetTimeout 30s, got %v", configuration.ResetTimeout)
 	}
-	if cfg.SuccessThreshold != 1 {
-		t.Errorf("expected SuccessThreshold 1, got %d", cfg.SuccessThreshold)
+	if configuration.SuccessThreshold != 1 {
+		t.Errorf("expected SuccessThreshold 1, got %d", configuration.SuccessThreshold)
 	}
 }
 
@@ -63,12 +63,12 @@ func TestCircuitBreakerClosed(t *testing.T) {
 }
 
 func TestCircuitBreakerOpensAfterFailures(t *testing.T) {
-	cfg := CircuitBreakerConfig{
+	configuration := CircuitBreakerConfig{
 		FailureThreshold: 2,
 		ResetTimeout:     time.Minute,
 		SuccessThreshold: 1,
 	}
-	cb := NewCircuitBreaker("test", cfg)
+	cb := NewCircuitBreaker("test", configuration)
 
 	testErr := errors.New("test error")
 
@@ -96,12 +96,12 @@ func TestCircuitBreakerOpensAfterFailures(t *testing.T) {
 }
 
 func TestCircuitBreakerRejectsWhenOpen(t *testing.T) {
-	cfg := CircuitBreakerConfig{
+	configuration := CircuitBreakerConfig{
 		FailureThreshold: 1,
 		ResetTimeout:     time.Hour, // Long timeout to keep circuit open
 		SuccessThreshold: 1,
 	}
-	cb := NewCircuitBreaker("test", cfg)
+	cb := NewCircuitBreaker("test", configuration)
 
 	// Open the circuit
 	cb.Execute(func() (interface{}, error) {
@@ -128,12 +128,12 @@ func TestCircuitBreakerRejectsWhenOpen(t *testing.T) {
 }
 
 func TestCircuitBreakerTransitionsToHalfOpen(t *testing.T) {
-	cfg := CircuitBreakerConfig{
+	configuration := CircuitBreakerConfig{
 		FailureThreshold: 1,
 		ResetTimeout:     50 * time.Millisecond,
 		SuccessThreshold: 1,
 	}
-	cb := NewCircuitBreaker("test", cfg)
+	cb := NewCircuitBreaker("test", configuration)
 
 	// Open the circuit
 	cb.Execute(func() (interface{}, error) {
@@ -164,12 +164,12 @@ func TestCircuitBreakerTransitionsToHalfOpen(t *testing.T) {
 }
 
 func TestCircuitBreakerHalfOpenFailureReopens(t *testing.T) {
-	cfg := CircuitBreakerConfig{
+	configuration := CircuitBreakerConfig{
 		FailureThreshold: 1,
 		ResetTimeout:     50 * time.Millisecond,
 		SuccessThreshold: 1,
 	}
-	cb := NewCircuitBreaker("test", cfg)
+	cb := NewCircuitBreaker("test", configuration)
 
 	// Open the circuit
 	cb.Execute(func() (interface{}, error) {
@@ -190,12 +190,12 @@ func TestCircuitBreakerHalfOpenFailureReopens(t *testing.T) {
 }
 
 func TestCircuitBreakerCaching(t *testing.T) {
-	cfg := CircuitBreakerConfig{
+	configuration := CircuitBreakerConfig{
 		FailureThreshold: 1,
 		ResetTimeout:     time.Hour,
 		SuccessThreshold: 1,
 	}
-	cb := NewCircuitBreaker("test", cfg)
+	cb := NewCircuitBreaker("test", configuration)
 
 	// Successful call - caches result
 	result, err := cb.Execute(func() (interface{}, error) {
@@ -250,12 +250,12 @@ func TestCircuitBreakerGetCached(t *testing.T) {
 }
 
 func TestCircuitBreakerReset(t *testing.T) {
-	cfg := CircuitBreakerConfig{
+	configuration := CircuitBreakerConfig{
 		FailureThreshold: 1,
 		ResetTimeout:     time.Hour,
 		SuccessThreshold: 1,
 	}
-	cb := NewCircuitBreaker("test", cfg)
+	cb := NewCircuitBreaker("test", configuration)
 
 	// Open the circuit
 	cb.Execute(func() (interface{}, error) {