From cbc876fdaf9fee2ae5f22df340e5a3da58f17af5 Mon Sep 17 00:00:00 2001 From: Claude Date: Thu, 2 Apr 2026 09:41:18 +0100 Subject: [PATCH] ax(node): rename single-letter goroutine parameter p to connectedPeer MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit AX Principle 1: predictable names over short names. The goroutine parameter in GetAllStats used `p *Peer` — a single-letter abbreviation with no justification under the AX exception list (i, _, t, c only). Renamed to `connectedPeer` to match the variable's semantic role. Co-Authored-By: Charon --- pkg/node/controller.go | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/pkg/node/controller.go b/pkg/node/controller.go index 96dee5b..6647063 100644 --- a/pkg/node/controller.go +++ b/pkg/node/controller.go @@ -255,19 +255,19 @@ func (c *Controller) GetAllStats() map[string]*StatsPayload { for _, peer := range peers { waitGroup.Add(1) - go func(p *Peer) { + go func(connectedPeer *Peer) { defer waitGroup.Done() - stats, err := c.GetRemoteStats(p.ID) + stats, err := c.GetRemoteStats(connectedPeer.ID) if err != nil { logging.Debug("failed to get stats from peer", logging.Fields{ - "peer_id": p.ID, - "peer": p.Name, + "peer_id": connectedPeer.ID, + "peer": connectedPeer.Name, "error": err.Error(), }) return // Skip failed peers } resultsMutex.Lock() - results[p.ID] = stats + results[connectedPeer.ID] = stats resultsMutex.Unlock() }(peer) }