From db80ce6ddee0d696949f18abeb4a9bcf83ef1483 Mon Sep 17 00:00:00 2001 From: Claude Date: Thu, 2 Apr 2026 13:27:05 +0100 Subject: [PATCH] ax(mining): rename wg to waitGroup in circuit breaker concurrency test AX Principle 1: predictable names over short names. wg requires mental mapping to WaitGroup; waitGroup is self-documenting. Co-Authored-By: Charon --- pkg/mining/circuit_breaker_test.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/pkg/mining/circuit_breaker_test.go b/pkg/mining/circuit_breaker_test.go index 637a1fe..1fd5ece 100644 --- a/pkg/mining/circuit_breaker_test.go +++ b/pkg/mining/circuit_breaker_test.go @@ -302,11 +302,11 @@ func TestCircuitBreaker_Reset_Good(t *testing.T) { func TestCircuitBreaker_Concurrency_Ugly(t *testing.T) { cb := NewCircuitBreaker("test", DefaultCircuitBreakerConfig()) - var wg sync.WaitGroup + var waitGroup sync.WaitGroup for i := 0; i < 100; i++ { - wg.Add(1) + waitGroup.Add(1) go func(n int) { - defer wg.Done() + defer waitGroup.Done() cb.Execute(func() (interface{}, error) { //nolint:errcheck if n%3 == 0 { return nil, errors.New("fail") @@ -315,7 +315,7 @@ func TestCircuitBreaker_Concurrency_Ugly(t *testing.T) { }) }(i) } - wg.Wait() + waitGroup.Wait() _ = cb.State() }