Snider/Mining
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

ax(ueps): rename value to tagValue in ReadAndVerify loop
Some checks are pending
Security Scan / security (push) Waiting to run
Details
Test / test (push) Waiting to run
Details

Browse source 
AX Principle 1: predictable names over short names. The generic
local variable `value` required surrounding context to understand;
`tagValue` is self-documenting at every read site in the switch.

Co-Authored-By: Charon <charon@lethean.io>
This commit is contained in:
Claude 2026-04-02 08:50:53 +01:00
parent d886b3905c
commit de6e4d019f
No known key found for this signature in database
GPG key ID: AF404715446AEB41
1 changed files with 14 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

28
pkg/ueps/reader.go
View file

@ -62,47 +62,47 @@ func ReadAndVerify(reader *bufio.Reader, sharedSecret []byte) (*ParsedPacket, er
length := int(lengthByte)
// 4. Read Value
value := make([]byte, length)
if _, err := io.ReadFull(reader, value); err != nil {
tagValue := make([]byte, length)
if _, err := io.ReadFull(reader, tagValue); err != nil {
return nil, err
}
// Store for processing
switch tag {
case TagVersion:
header.Version = value[0]
header.Version = tagValue[0]
// Reconstruct signed data: Tag + Len + Val
signedData.WriteByte(tag)
signedData.WriteByte(byte(length))
signedData.Write(value)
signedData.Write(tagValue)
case TagCurrentLayer:
header.CurrentLayer = value[0]
header.CurrentLayer = tagValue[0]
signedData.WriteByte(tag)
signedData.WriteByte(byte(length))
signedData.Write(value)
signedData.Write(tagValue)
case TagTargetLayer:
header.TargetLayer = value[0]
header.TargetLayer = tagValue[0]
signedData.WriteByte(tag)
signedData.WriteByte(byte(length))
signedData.Write(value)
signedData.Write(tagValue)
case TagIntent:
header.IntentID = value[0]
header.IntentID = tagValue[0]
signedData.WriteByte(tag)
signedData.WriteByte(byte(length))
signedData.Write(value)
signedData.Write(tagValue)
case TagThreatScore:
header.ThreatScore = binary.BigEndian.Uint16(value)
header.ThreatScore = binary.BigEndian.Uint16(tagValue)
signedData.WriteByte(tag)
signedData.WriteByte(byte(length))
signedData.Write(value)
signedData.Write(tagValue)
case TagHMAC:
signature = value
signature = tagValue
// We do NOT add the HMAC itself to signedData
default:
// Unknown tag (future proofing), verify it but ignore semantics
signedData.WriteByte(tag)
signedData.WriteByte(byte(length))
signedData.Write(value)
signedData.Write(tagValue)
}
}