Snider/Mining
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

ax(ueps): replace abbreviated buf with buffer in writeTLV usage example comments

Browse source 
AX Principle 1 — predictable names over short names. Test comments showing
writeTLV usage had buf (abbreviated) while the actual code used buffer
(descriptive). Comments are usage examples that agents learn from; the name
must match what an agent would write.

Co-Authored-By: Charon <charon@lethean.io>
This commit is contained in:
Claude 2026-04-02 09:26:11 +01:00
parent 3ed2453413
commit eafd673d13
No known key found for this signature in database
GPG key ID: AF404715446AEB41
1 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
pkg/ueps/packet_test.go
View file

@ -145,8 +145,8 @@ func TestPacket_MarshalAndSign_Ugly(t *testing.T) {
}
}
// writeTLV(buf, TagVersion, []byte{0x09})
// // buf contains: [0x01, 0x01, 0x09]
// writeTLV(buffer, TagVersion, []byte{0x09})
// // buffer contains: [0x01, 0x01, 0x09]
func TestPacket_writeTLV_Good(t *testing.T) {
buffer := new(bytes.Buffer)
@ -170,7 +170,7 @@ func TestPacket_writeTLV_Good(t *testing.T) {
}
}
// writeTLV(buf, TagPayload, bytes.Repeat([]byte("x"), 256))
// writeTLV(buffer, TagPayload, bytes.Repeat([]byte("x"), 256))
// // returns error: "TLV value too large for 1-byte length header"
func TestPacket_writeTLV_Bad(t *testing.T) {
buffer := new(bytes.Buffer)
@ -183,8 +183,8 @@ func TestPacket_writeTLV_Bad(t *testing.T) {
}
}
// writeTLV(buf, TagIntent, []byte{})
// // buf contains: [0x04, 0x00] (tag + zero length, no value bytes)
// writeTLV(buffer, TagIntent, []byte{})
// // buffer contains: [0x04, 0x00] (tag + zero length, no value bytes)
func TestPacket_writeTLV_Ugly(t *testing.T) {
buffer := new(bytes.Buffer)