Snider/Mining
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

ax(mining): replace prose comments with usage examples in miner_factory

Browse source 
Two Principle 2 violations: globalFactory had a description comment instead
of a usage example, and registerDefaults restated the function name.

Co-Authored-By: Charon <charon@lethean.io>
This commit is contained in:
Claude 2026-04-02 13:30:49 +01:00
parent 84d0515974
commit ee8e6e1299
No known key found for this signature in database
GPG key ID: AF404715446AEB41
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
pkg/mining/miner_factory.go
View file

@ -16,7 +16,8 @@ type MinerFactory struct {
aliases map[string]string // maps aliases to canonical names
}
// globalFactory is the default factory instance
// globalFactory := NewMinerFactory()
// miner, err := globalFactory.Create("xmrig")
var globalFactory = NewMinerFactory()
// factory := NewMinerFactory()
@ -30,7 +31,7 @@ func NewMinerFactory() *MinerFactory {
return factory
}
// registerDefaults registers all built-in miners
// factory.registerDefaults() // called in NewMinerFactory(); adds xmrig, tt-miner, simulated to constructors
func (factory *MinerFactory) registerDefaults() {
// XMRig miner (CPU/GPU RandomX, Cryptonight, etc.)
factory.Register("xmrig", func() Miner { return NewXMRigMiner() })