Snider/Mining
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

ax(ueps): name magic secret literals in NewPacketBuilder tests
Some checks failed
Test / test (push) Waiting to run
Details
Security Scan / security (push) Has been cancelled
Details

Browse source 
TestPacket_NewPacketBuilder_Bad and _Ugly used inline []byte("secret")
literals; extracted to sharedSecret variable per AX Principle 1
(predictable names over magic literals).

Co-Authored-By: Charon <charon@lethean.io>
This commit is contained in:
Claude 2026-04-02 14:12:18 +01:00
parent 9076b77596
commit f8d3ee8c98
No known key found for this signature in database
GPG key ID: AF404715446AEB41
1 changed files with 6 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
pkg/ueps/packet_test.go
View file

@ -38,8 +38,9 @@ func TestPacket_NewPacketBuilder_Good(t *testing.T) {
}
// builder := NewPacketBuilder(0x04, nil)
// frame, err := builder.MarshalAndSign(secret) // succeeds with zero-length payload
// frame, err := builder.MarshalAndSign([]byte("shared-secret")) // succeeds with zero-length payload
func TestPacket_NewPacketBuilder_Bad(t *testing.T) {
sharedSecret := []byte("shared-secret")
builder := NewPacketBuilder(0x04, nil)
if builder == nil {
@ -49,7 +50,7 @@ func TestPacket_NewPacketBuilder_Bad(t *testing.T) {
t.Errorf("expected nil Payload, got %v", builder.Payload)
}
frame, err := builder.MarshalAndSign([]byte("secret"))
frame, err := builder.MarshalAndSign(sharedSecret)
if err != nil {
t.Fatalf("MarshalAndSign with nil payload failed: %v", err)
}
@ -59,8 +60,9 @@ func TestPacket_NewPacketBuilder_Bad(t *testing.T) {
}
// builder := NewPacketBuilder(0x00, largePayload)
// frame, err := builder.MarshalAndSign(secret) // succeeds; 0xFF tag appended without length prefix
// frame, err := builder.MarshalAndSign([]byte("shared-secret")) // succeeds; 0xFF tag appended without length prefix
func TestPacket_NewPacketBuilder_Ugly(t *testing.T) {
sharedSecret := []byte("shared-secret")
largePayload := bytes.Repeat([]byte("x"), 300)
builder := NewPacketBuilder(0x00, largePayload)
@ -68,7 +70,7 @@ func TestPacket_NewPacketBuilder_Ugly(t *testing.T) {
t.Errorf("expected IntentID 0x00, got 0x%02x", builder.Header.IntentID)
}
frame, err := builder.MarshalAndSign([]byte("secret"))
frame, err := builder.MarshalAndSign(sharedSecret)
if err != nil {
t.Fatalf("MarshalAndSign with 300-byte payload failed: %v", err)
}