Commit graph

6 commits

Author SHA1 Message Date
Virgil
976ff0141c refactor(ax): tighten remaining naming and docs
Some checks are pending
Security Scan / security (push) Waiting to run
Test / test (push) Waiting to run
Co-Authored-By: Virgil <virgil@lethean.io>
2026-04-04 05:08:34 +00:00
Claude
aa69d9c933
ax(node): add Good and Ugly test variants for GetChainInfo, DiscoverPools, DiscoverGateways
AX principle 10 requires all three test categories (Good, Bad, Ugly).
lethean_test.go only had Bad variants for the three discovery functions;
added Good (happy-path via httptest.Server) and Ugly (edge-case filtering
and malformed JSON) for each, using a local test server to avoid live daemon dependency.

Co-Authored-By: Charon <charon@lethean.io>
2026-04-02 16:54:59 +01:00
Claude
acef50ad62
ax(node): rename tt loop variable to testCase in lethean_test.go
Some checks are pending
Security Scan / security (push) Waiting to run
Test / test (push) Waiting to run
AX Principle #1 — predictable names over short names. The `tt` loop variable
is a two-letter abbreviation with no defined exception in the AX naming rules
(only `i`, `_`, `t`, `c` are acceptable short names). Renamed to `testCase`
throughout TestParseComment_{Good,Bad,Ugly}.

Co-Authored-By: Charon <charon@lethean.io>
2026-04-02 16:36:41 +01:00
Claude
8a899153ed
ax(node): strip _WrongURL suffix from lethean test names
Some checks failed
Security Scan / security (push) Successful in 34s
Test / test (push) Has been cancelled
Test names must follow TestFilename_Function_{Good,Bad,Ugly}.
The extra _WrongURL qualifier broke the AX naming convention
(RFC-CORE-008 §10 — CLI tests as artifact validation).

Co-Authored-By: Charon <charon@lethean.io>
2026-04-02 12:23:44 +01:00
Claude
6555e1211c
ax(node): add missing Bad and Ugly test triads for parseComment
Some checks are pending
Security Scan / security (push) Waiting to run
Test / test (push) Waiting to run
AX principle 10 requires all three categories (Good, Bad, Ugly) per
function. lethean_test.go had only Good for parseComment; Bad (invalid
input, missing keys, empty values) and Ugly (empty string, semicolons
only, duplicate keys, value-with-equals) are now present.

Co-Authored-By: Charon <charon@lethean.io>
2026-04-02 08:12:03 +01:00
Claude
7c6645fbeb
feat(node): add Lethean chain discovery for mining fleet
Some checks are pending
Security Scan / security (push) Waiting to run
Test / test (push) Waiting to run
Chain integration for P2P mining nodes:
- GetChainInfo — query daemon for height, aliases, sync status
- DiscoverPools — find pool aliases from chain (cap=pool)
- DiscoverGateways — find gateway nodes from chain
- parseComment — v=lthn1 comment parser

Constants: testnet/mainnet daemon URLs and pool endpoints.
4/4 tests passing.

Co-Authored-By: Charon <charon@lethean.io>
2026-04-02 07:24:28 +01:00