agent/pkg/agentic/dispatch_sync_test.go

156 lines
5.2 KiB
Go
Raw Normal View History

// SPDX-License-Identifier: EUPL-1.2
package agentic
import (
"context"
"testing"
"time"
core "dappco.re/go/core"
"github.com/modelcontextprotocol/go-sdk/mcp"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
)
feat: AX v0.8.0 upgrade — Core features + quality gates AX Quality Gates (RFC-025): - Eliminate os/exec from all test + production code (12+ files) - Eliminate encoding/json from all test files (15 files, 66 occurrences) - Eliminate os from all test files except TestMain (Go runtime contract) - Eliminate path/filepath, net/url from all files - String concat: 39 violations replaced with core.Concat() - Test naming AX-7: 264 test functions renamed across all 6 packages - Example test 1:1 coverage complete Core Features Adopted: - Task Composition: agent.completion pipeline (QA → PR → Verify → Ingest → Poke) - PerformAsync: completion pipeline runs with WaitGroup + progress tracking - Config: agents.yaml loaded once, feature flags (auto-qa/pr/merge/ingest) - Named Locks: c.Lock("drain") for queue serialisation - Registry: workspace state with cross-package QUERY access - QUERY: c.QUERY(WorkspaceQuery{Status: "running"}) for cross-service queries - Action descriptions: 25+ Actions self-documenting - Data mounts: prompts/tasks/flows/personas/workspaces via c.Data() - Content Actions: agentic.prompt/task/flow/persona callable via IPC - Drive endpoints: forge + brain registered with tokens - Drive REST helpers: DriveGet/DrivePost/DriveDo for Drive-aware HTTP - HandleIPCEvents: auto-discovered by WithService (no manual wiring) - Entitlement: frozen-queue gate on write Actions - CLI dispatch: workspace dispatch wired to real dispatch method - CLI: --quiet/-q and --debug/-d global flags - CLI: banner, version, check (with service/action/command counts), env - main.go: minimal — 5 services + c.Run(), no os import - cmd tests: 84.2% coverage (was 0%) Co-Authored-By: Virgil <virgil@lethean.io>
2026-03-26 06:38:02 +00:00
func TestDispatchsync_ContainerCommand_Good(t *testing.T) {
cmd, args := containerCommand("codex", []string{"--model", "gpt-5.4"}, "/workspace/task-5", "/workspace/task-5/.meta")
assert.Equal(t, "docker", cmd)
assert.Contains(t, args, "run")
assert.Contains(t, args, "/workspace/task-5:/workspace")
assert.Contains(t, args, "/workspace/task-5/.meta:/workspace/.meta")
assert.Contains(t, args, "/workspace/repo")
}
feat: AX v0.8.0 upgrade — Core features + quality gates AX Quality Gates (RFC-025): - Eliminate os/exec from all test + production code (12+ files) - Eliminate encoding/json from all test files (15 files, 66 occurrences) - Eliminate os from all test files except TestMain (Go runtime contract) - Eliminate path/filepath, net/url from all files - String concat: 39 violations replaced with core.Concat() - Test naming AX-7: 264 test functions renamed across all 6 packages - Example test 1:1 coverage complete Core Features Adopted: - Task Composition: agent.completion pipeline (QA → PR → Verify → Ingest → Poke) - PerformAsync: completion pipeline runs with WaitGroup + progress tracking - Config: agents.yaml loaded once, feature flags (auto-qa/pr/merge/ingest) - Named Locks: c.Lock("drain") for queue serialisation - Registry: workspace state with cross-package QUERY access - QUERY: c.QUERY(WorkspaceQuery{Status: "running"}) for cross-service queries - Action descriptions: 25+ Actions self-documenting - Data mounts: prompts/tasks/flows/personas/workspaces via c.Data() - Content Actions: agentic.prompt/task/flow/persona callable via IPC - Drive endpoints: forge + brain registered with tokens - Drive REST helpers: DriveGet/DrivePost/DriveDo for Drive-aware HTTP - HandleIPCEvents: auto-discovered by WithService (no manual wiring) - Entitlement: frozen-queue gate on write Actions - CLI dispatch: workspace dispatch wired to real dispatch method - CLI: --quiet/-q and --debug/-d global flags - CLI: banner, version, check (with service/action/command counts), env - main.go: minimal — 5 services + c.Run(), no os import - cmd tests: 84.2% coverage (was 0%) Co-Authored-By: Virgil <virgil@lethean.io>
2026-03-26 06:38:02 +00:00
func TestDispatchsync_ContainerCommand_Bad_UnknownAgent(t *testing.T) {
cmd, args := containerCommand("unknown", nil, "/workspace/task-5", "/workspace/task-5/.meta")
assert.Equal(t, "docker", cmd)
assert.NotEmpty(t, args)
}
feat: AX v0.8.0 upgrade — Core features + quality gates AX Quality Gates (RFC-025): - Eliminate os/exec from all test + production code (12+ files) - Eliminate encoding/json from all test files (15 files, 66 occurrences) - Eliminate os from all test files except TestMain (Go runtime contract) - Eliminate path/filepath, net/url from all files - String concat: 39 violations replaced with core.Concat() - Test naming AX-7: 264 test functions renamed across all 6 packages - Example test 1:1 coverage complete Core Features Adopted: - Task Composition: agent.completion pipeline (QA → PR → Verify → Ingest → Poke) - PerformAsync: completion pipeline runs with WaitGroup + progress tracking - Config: agents.yaml loaded once, feature flags (auto-qa/pr/merge/ingest) - Named Locks: c.Lock("drain") for queue serialisation - Registry: workspace state with cross-package QUERY access - QUERY: c.QUERY(WorkspaceQuery{Status: "running"}) for cross-service queries - Action descriptions: 25+ Actions self-documenting - Data mounts: prompts/tasks/flows/personas/workspaces via c.Data() - Content Actions: agentic.prompt/task/flow/persona callable via IPC - Drive endpoints: forge + brain registered with tokens - Drive REST helpers: DriveGet/DrivePost/DriveDo for Drive-aware HTTP - HandleIPCEvents: auto-discovered by WithService (no manual wiring) - Entitlement: frozen-queue gate on write Actions - CLI dispatch: workspace dispatch wired to real dispatch method - CLI: --quiet/-q and --debug/-d global flags - CLI: banner, version, check (with service/action/command counts), env - main.go: minimal — 5 services + c.Run(), no os import - cmd tests: 84.2% coverage (was 0%) Co-Authored-By: Virgil <virgil@lethean.io>
2026-03-26 06:38:02 +00:00
func TestDispatchsync_ContainerCommand_Ugly_EmptyArgs(t *testing.T) {
assert.NotPanics(t, func() {
containerCommand("codex", nil, "", "")
})
}
func TestDispatchsync_HandleDispatchSync_Good_Completed(t *testing.T) {
dir := t.TempDir()
setTestWorkspace(t, dir)
workspaceDir := core.JoinPath(WorkspaceRoot(), "core", "go-io", "task-7")
s := &PrepSubsystem{dispatchSyncTick: 10 * time.Millisecond}
s.dispatchSyncPrep = func(ctx context.Context, _ *mcp.CallToolRequest, input PrepInput) (*mcp.CallToolResult, PrepOutput, error) {
require.Equal(t, "core", input.Org)
require.Equal(t, "go-io", input.Repo)
require.Equal(t, "codex", input.Agent)
require.Equal(t, "Fix tests", input.Task)
require.Equal(t, 7, input.Issue)
require.True(t, fs.EnsureDir(workspaceDir).OK)
require.True(t, fs.Write(core.JoinPath(workspaceDir, "status.json"), core.JSONMarshalString(&WorkspaceStatus{
Status: "completed",
PRURL: "https://forge.test/core/go-io/pulls/7",
})).OK)
return nil, PrepOutput{
Success: true,
WorkspaceDir: workspaceDir,
Branch: "agent/fix-tests",
Prompt: "prompt",
}, nil
}
s.dispatchSyncSpawn = func(agent, prompt, dir string) (int, string, string, error) {
require.Equal(t, "codex", agent)
require.Equal(t, "prompt", prompt)
require.Equal(t, workspaceDir, dir)
return 321, "process-321", core.JoinPath(dir, ".meta", "agent.log"), nil
}
result := s.handleDispatchSync(context.Background(), core.NewOptions(
core.Option{Key: "org", Value: "core"},
core.Option{Key: "repo", Value: "go-io"},
core.Option{Key: "agent", Value: "codex"},
core.Option{Key: "task", Value: "Fix tests"},
core.Option{Key: "issue", Value: "7"},
))
require.True(t, result.OK)
output, ok := result.Value.(DispatchSyncResult)
require.True(t, ok)
assert.True(t, output.OK)
assert.Equal(t, "completed", output.Status)
assert.Equal(t, "https://forge.test/core/go-io/pulls/7", output.PRURL)
}
func TestDispatchsync_HandleDispatchSync_Bad_PrepFailure(t *testing.T) {
s := &PrepSubsystem{}
s.dispatchSyncPrep = func(context.Context, *mcp.CallToolRequest, PrepInput) (*mcp.CallToolResult, PrepOutput, error) {
return nil, PrepOutput{}, core.E("prepWorkspace", "boom", nil)
}
result := s.handleDispatchSync(context.Background(), core.NewOptions(
core.Option{Key: "repo", Value: "go-io"},
core.Option{Key: "task", Value: "Fix tests"},
))
assert.False(t, result.OK)
require.Error(t, result.Value.(error))
assert.Contains(t, result.Value.(error).Error(), "prep workspace failed")
}
func TestDispatchsync_HandleDispatchSync_Bad_PrepIncomplete(t *testing.T) {
s := &PrepSubsystem{}
s.dispatchSyncPrep = func(context.Context, *mcp.CallToolRequest, PrepInput) (*mcp.CallToolResult, PrepOutput, error) {
return nil, PrepOutput{
Success: false,
}, nil
}
result := s.handleDispatchSync(context.Background(), core.NewOptions(
core.Option{Key: "repo", Value: "go-io"},
core.Option{Key: "task", Value: "Fix tests"},
))
assert.False(t, result.OK)
require.Error(t, result.Value.(error))
assert.Contains(t, result.Value.(error).Error(), "prep failed")
}
func TestDispatchsync_HandleDispatchSync_Ugly_SpawnFailure(t *testing.T) {
dir := t.TempDir()
setTestWorkspace(t, dir)
workspaceDir := core.JoinPath(WorkspaceRoot(), "core", "go-io", "task-7")
s := &PrepSubsystem{dispatchSyncTick: 10 * time.Millisecond}
s.dispatchSyncPrep = func(context.Context, *mcp.CallToolRequest, PrepInput) (*mcp.CallToolResult, PrepOutput, error) {
require.True(t, fs.EnsureDir(workspaceDir).OK)
require.True(t, fs.Write(core.JoinPath(workspaceDir, "status.json"), core.JSONMarshalString(&WorkspaceStatus{
Status: "running",
})).OK)
return nil, PrepOutput{
Success: true,
WorkspaceDir: workspaceDir,
Branch: "agent/fix-tests",
Prompt: "prompt",
}, nil
}
s.dispatchSyncSpawn = func(agent, prompt, dir string) (int, string, string, error) {
require.Equal(t, "codex", agent)
return 0, "", "", core.E("spawn", "boom", nil)
}
result := s.handleDispatchSync(context.Background(), core.NewOptions(
core.Option{Key: "repo", Value: "go-io"},
core.Option{Key: "agent", Value: "codex"},
core.Option{Key: "task", Value: "Fix tests"},
))
assert.False(t, result.OK)
require.Error(t, result.Value.(error))
assert.Contains(t, result.Value.(error).Error(), "spawn agent failed")
}