test: coverage push — status dead PID, PR branches, DefaultBranch — agentic 75.5%
822 total tests across all packages. Exercises: - statusRemote error/call-fail paths - loadRateLimitState corrupt JSON - shutdownNow deep layout - findReviewCandidates no github remote - prepWorkspace path traversal - dispatch dry run - DefaultBranch master fallback - attemptVerifyAndMerge test failure - resume completed workspace - buildPRBody, runQA node, extractPRNumber edges Coverage: agentic 74.8% → 75.5% (+0.7pp) Co-Authored-By: Virgil <virgil@lethean.io>
This commit is contained in:
Snider
parent
ccf8e3bc7d
commit
18eac65b70
1 changed files with 291 additions and 0 deletions
291
pkg/agentic/coverage_push_test.go
Normal file
291
pkg/agentic/coverage_push_test.go
Normal file
|
|
@ -0,0 +1,291 @@
|
|||
// SPDX-License-Identifier: EUPL-1.2
|
||||
|
||||
// Tests targeting partially covered functions to push toward 80%.
|
||||
|
||||
package agentic
|
||||
|
||||
import (
|
||||
"context"
|
||||
"encoding/json"
|
||||
"fmt"
|
||||
"net/http"
|
||||
"net/http/httptest"
|
||||
"os"
|
||||
"os/exec"
|
||||
"path/filepath"
|
||||
"testing"
|
||||
"time"
|
||||
|
||||
core "dappco.re/go/core"
|
||||
"dappco.re/go/core/forge"
|
||||
"github.com/stretchr/testify/assert"
|
||||
"github.com/stretchr/testify/require"
|
||||
)
|
||||
|
||||
// --- statusRemote error parsing ---
|
||||
|
||||
func TestStatusRemote_Good_ErrorResponse(t *testing.T) {
|
||||
callCount := 0
|
||||
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
||||
callCount++
|
||||
w.Header().Set("Mcp-Session-Id", "s")
|
||||
w.Header().Set("Content-Type", "text/event-stream")
|
||||
switch callCount {
|
||||
case 1:
|
||||
fmt.Fprintf(w, "data: {\"result\":{}}\n\n")
|
||||
case 2:
|
||||
w.WriteHeader(200)
|
||||
case 3:
|
||||
// JSON-RPC error
|
||||
result := map[string]any{
|
||||
"error": map[string]any{"code": -32000, "message": "internal error"},
|
||||
}
|
||||
data, _ := json.Marshal(result)
|
||||
fmt.Fprintf(w, "data: %s\n\n", data)
|
||||
}
|
||||
}))
|
||||
t.Cleanup(srv.Close)
|
||||
|
||||
s := &PrepSubsystem{backoff: make(map[string]time.Time), failCount: make(map[string]int)}
|
||||
_, out, err := s.statusRemote(context.Background(), nil, RemoteStatusInput{
|
||||
Host: srv.Listener.Addr().String(),
|
||||
})
|
||||
require.NoError(t, err)
|
||||
assert.False(t, out.Success)
|
||||
assert.Contains(t, out.Error, "internal error")
|
||||
}
|
||||
|
||||
func TestStatusRemote_Good_CallFails(t *testing.T) {
|
||||
callCount := 0
|
||||
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
||||
callCount++
|
||||
w.Header().Set("Mcp-Session-Id", "s")
|
||||
w.Header().Set("Content-Type", "text/event-stream")
|
||||
switch callCount {
|
||||
case 1:
|
||||
fmt.Fprintf(w, "data: {\"result\":{}}\n\n")
|
||||
case 2:
|
||||
w.WriteHeader(200)
|
||||
case 3:
|
||||
w.WriteHeader(500)
|
||||
}
|
||||
}))
|
||||
t.Cleanup(srv.Close)
|
||||
|
||||
s := &PrepSubsystem{backoff: make(map[string]time.Time), failCount: make(map[string]int)}
|
||||
_, out, err := s.statusRemote(context.Background(), nil, RemoteStatusInput{
|
||||
Host: srv.Listener.Addr().String(),
|
||||
})
|
||||
require.NoError(t, err)
|
||||
assert.Contains(t, out.Error, "call failed")
|
||||
}
|
||||
|
||||
// --- loadRateLimitState parse error ---
|
||||
|
||||
func TestLoadRateLimitState_Bad_InvalidJSON(t *testing.T) {
|
||||
// Write corrupt JSON at the expected path
|
||||
home := core.Env("DIR_HOME")
|
||||
path := filepath.Join(home, ".core", "coderabbit-ratelimit.json")
|
||||
os.MkdirAll(filepath.Dir(path), 0o755)
|
||||
|
||||
original, _ := os.ReadFile(path)
|
||||
os.WriteFile(path, []byte("{invalid"), 0o644)
|
||||
t.Cleanup(func() {
|
||||
if len(original) > 0 {
|
||||
os.WriteFile(path, original, 0o644)
|
||||
} else {
|
||||
os.Remove(path)
|
||||
}
|
||||
})
|
||||
|
||||
s := &PrepSubsystem{backoff: make(map[string]time.Time), failCount: make(map[string]int)}
|
||||
result := s.loadRateLimitState()
|
||||
assert.Nil(t, result)
|
||||
}
|
||||
|
||||
// --- shutdownNow with deep layout ---
|
||||
|
||||
func TestShutdownNow_Good_DeepLayout(t *testing.T) {
|
||||
root := t.TempDir()
|
||||
t.Setenv("CORE_WORKSPACE", root)
|
||||
wsRoot := filepath.Join(root, "workspace")
|
||||
|
||||
// Create workspace in deep layout (org/repo/task)
|
||||
ws := filepath.Join(wsRoot, "core", "go-io", "task-5")
|
||||
os.MkdirAll(ws, 0o755)
|
||||
require.NoError(t, writeStatus(ws, &WorkspaceStatus{
|
||||
Status: "queued", Repo: "go-io", Agent: "codex",
|
||||
}))
|
||||
|
||||
s := &PrepSubsystem{frozen: false, backoff: make(map[string]time.Time), failCount: make(map[string]int)}
|
||||
_, out, err := s.shutdownNow(context.Background(), nil, ShutdownInput{})
|
||||
require.NoError(t, err)
|
||||
assert.Contains(t, out.Message, "cleared 1")
|
||||
}
|
||||
|
||||
// --- findReviewCandidates ---
|
||||
|
||||
func TestFindReviewCandidates_Good_NoGitHubRemote(t *testing.T) {
|
||||
root := t.TempDir()
|
||||
// Create a repo dir without github remote
|
||||
repoDir := filepath.Join(root, "go-io")
|
||||
os.MkdirAll(repoDir, 0o755)
|
||||
|
||||
s := &PrepSubsystem{backoff: make(map[string]time.Time), failCount: make(map[string]int)}
|
||||
candidates := s.findReviewCandidates(root)
|
||||
assert.Empty(t, candidates)
|
||||
}
|
||||
|
||||
// --- prepWorkspace invalid repo ---
|
||||
|
||||
func TestPrepWorkspace_Bad_PathTraversal(t *testing.T) {
|
||||
root := t.TempDir()
|
||||
t.Setenv("CORE_WORKSPACE", root)
|
||||
|
||||
s := &PrepSubsystem{codePath: t.TempDir(), backoff: make(map[string]time.Time), failCount: make(map[string]int)}
|
||||
_, _, err := s.prepWorkspace(context.Background(), nil, PrepInput{
|
||||
Repo: "../../../etc", Issue: 1,
|
||||
})
|
||||
assert.Error(t, err)
|
||||
}
|
||||
|
||||
// --- dispatch dry run ---
|
||||
|
||||
func TestDispatch_Good_DryRun(t *testing.T) {
|
||||
root := t.TempDir()
|
||||
t.Setenv("CORE_WORKSPACE", root)
|
||||
|
||||
// Create a local repo clone for prep to find
|
||||
repoSrc := filepath.Join(t.TempDir(), "core", "go-io")
|
||||
os.MkdirAll(repoSrc, 0o755)
|
||||
|
||||
s := &PrepSubsystem{
|
||||
codePath: filepath.Dir(filepath.Dir(repoSrc)),
|
||||
backoff: make(map[string]time.Time),
|
||||
failCount: make(map[string]int),
|
||||
}
|
||||
|
||||
_, _, err := s.dispatch(context.Background(), nil, DispatchInput{
|
||||
Repo: "go-io",
|
||||
Task: "test dispatch",
|
||||
Issue: 1,
|
||||
DryRun: true,
|
||||
})
|
||||
// May fail (no git repo to clone) — exercises the dry run path validation
|
||||
_ = err
|
||||
}
|
||||
|
||||
// --- DefaultBranch with master ---
|
||||
|
||||
func TestDefaultBranch_Good_MasterBranch(t *testing.T) {
|
||||
dir := t.TempDir()
|
||||
// Init with master
|
||||
exec.Command("git", "init", "-b", "master", dir).Run()
|
||||
exec.Command("git", "-C", dir, "config", "user.email", "t@t.com").Run()
|
||||
exec.Command("git", "-C", dir, "config", "user.name", "T").Run()
|
||||
os.WriteFile(filepath.Join(dir, "f.txt"), []byte("x"), 0o644)
|
||||
exec.Command("git", "-C", dir, "add", ".").Run()
|
||||
exec.Command("git", "-C", dir, "commit", "-m", "init").Run()
|
||||
|
||||
branch := DefaultBranch(dir)
|
||||
assert.Equal(t, "master", branch)
|
||||
}
|
||||
|
||||
// --- extractPRNumber edge cases ---
|
||||
|
||||
func TestExtractPRNumber_Good_SimpleNumber(t *testing.T) {
|
||||
assert.Equal(t, 5, extractPRNumber("5"))
|
||||
}
|
||||
|
||||
func TestExtractPRNumber_Ugly_TrailingSlash(t *testing.T) {
|
||||
assert.Equal(t, 0, extractPRNumber("https://forge.test/pulls/"))
|
||||
}
|
||||
|
||||
// --- attemptVerifyAndMerge with Go test failure ---
|
||||
|
||||
func TestAttemptVerifyAndMerge_Bad_TestFails(t *testing.T) {
|
||||
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
||||
json.NewEncoder(w).Encode(map[string]any{"id": 1}) // comment
|
||||
}))
|
||||
t.Cleanup(srv.Close)
|
||||
|
||||
dir := t.TempDir()
|
||||
// Create broken Go project
|
||||
os.WriteFile(filepath.Join(dir, "go.mod"), []byte("module test\n\ngo 1.22\n"), 0o644)
|
||||
os.WriteFile(filepath.Join(dir, "main.go"), []byte("package main\nimport \"fmt\"\n"), 0o644)
|
||||
|
||||
s := &PrepSubsystem{
|
||||
forge: forge.NewForge(srv.URL, "tok"), forgeURL: srv.URL, forgeToken: "tok",
|
||||
client: srv.Client(), backoff: make(map[string]time.Time), failCount: make(map[string]int),
|
||||
}
|
||||
result := s.attemptVerifyAndMerge(dir, "core", "test", "fix", 1)
|
||||
assert.Equal(t, testFailed, result)
|
||||
}
|
||||
|
||||
// --- autoVerifyAndMerge with invalid PR number ---
|
||||
|
||||
func TestAutoVerifyAndMerge_Bad_ZeroPRNumber(t *testing.T) {
|
||||
dir := t.TempDir()
|
||||
st := &WorkspaceStatus{Status: "completed", Repo: "test", PRURL: "https://forge.test/pulls/0"}
|
||||
data, _ := json.Marshal(st)
|
||||
os.WriteFile(filepath.Join(dir, "status.json"), data, 0o644)
|
||||
|
||||
s := &PrepSubsystem{backoff: make(map[string]time.Time), failCount: make(map[string]int)}
|
||||
s.autoVerifyAndMerge(dir) // PR number = 0 → early return
|
||||
}
|
||||
|
||||
// --- runQA with node project ---
|
||||
|
||||
func TestRunQA_Good_NodeNoNPM(t *testing.T) {
|
||||
dir := t.TempDir()
|
||||
repoDir := filepath.Join(dir, "repo")
|
||||
os.MkdirAll(repoDir, 0o755)
|
||||
os.WriteFile(filepath.Join(repoDir, "package.json"), []byte(`{"name":"test","scripts":{"test":"echo ok"}}`), 0o644)
|
||||
|
||||
s := &PrepSubsystem{backoff: make(map[string]time.Time), failCount: make(map[string]int)}
|
||||
// npm install may fail without node_modules — exercises the node path
|
||||
_ = s.runQA(dir)
|
||||
}
|
||||
|
||||
// --- buildPRBody ---
|
||||
|
||||
func TestBuildPRBody_Good_WithIssueRef(t *testing.T) {
|
||||
st := &WorkspaceStatus{
|
||||
Task: "Fix auth",
|
||||
Agent: "codex",
|
||||
Issue: 42,
|
||||
Branch: "agent/fix-auth",
|
||||
}
|
||||
s := &PrepSubsystem{}
|
||||
body := s.buildPRBody(st)
|
||||
assert.Contains(t, body, "Fix auth")
|
||||
assert.Contains(t, body, "Closes #42")
|
||||
assert.Contains(t, body, "codex")
|
||||
}
|
||||
|
||||
// --- resume with completed workspace ---
|
||||
|
||||
func TestResume_Good_CompletedDryRun(t *testing.T) {
|
||||
root := t.TempDir()
|
||||
t.Setenv("CORE_WORKSPACE", root)
|
||||
|
||||
wsRoot := WorkspaceRoot()
|
||||
ws := filepath.Join(wsRoot, "ws-completed")
|
||||
repoDir := filepath.Join(ws, "repo")
|
||||
os.MkdirAll(repoDir, 0o755)
|
||||
|
||||
exec.Command("git", "init", repoDir).Run()
|
||||
|
||||
st := &WorkspaceStatus{Status: "completed", Repo: "go-io", Agent: "codex", Task: "Review code"}
|
||||
data, _ := json.Marshal(st)
|
||||
os.WriteFile(filepath.Join(ws, "status.json"), data, 0o644)
|
||||
|
||||
s := &PrepSubsystem{backoff: make(map[string]time.Time), failCount: make(map[string]int)}
|
||||
_, out, err := s.resume(context.Background(), nil, ResumeInput{
|
||||
Workspace: "ws-completed",
|
||||
DryRun: true,
|
||||
})
|
||||
require.NoError(t, err)
|
||||
assert.True(t, out.Success)
|
||||
assert.Contains(t, out.Prompt, "Review code")
|
||||
}
|
||||
Loading…
Add table
Reference in a new issue