core/agent
8
0
Fork 0
Code Issues 5 Pull requests Projects Releases Packages Wiki Activity Actions

fix(agentic): reject empty MCP session ids

Browse source 
Co-Authored-By: Virgil <virgil@lethean.io>
This commit is contained in:
Snider 2026-04-17 20:50:17 +01:00
parent ccedf536d6
commit 4cea9555d4
2 changed files with 15 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
pkg/agentic/remote_client_test.go
View file

@ -59,6 +59,18 @@ func TestRemoteclient_McpInitialize_Bad_ServerError(t *testing.T) {
assert.Contains(t, err.Error(), "HTTP 500")
}
func TestRemoteclient_McpInitialize_Bad_MissingSessionID(t *testing.T) {
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
w.Header().Set("Content-Type", "text/event-stream")
fmt.Fprintf(w, "data: {\"result\":{}}\n\n")
}))
t.Cleanup(srv.Close)
_, err := mcpInitialize(context.Background(), srv.URL, "")
require.Error(t, err)
assert.Contains(t, err.Error(), "missing session id")
}
func TestRemoteclient_McpInitialize_Bad_Unreachable(t *testing.T) {
_, err := mcpInitialize(context.Background(), "http://127.0.0.1:1", "")
assert.Error(t, err)

3
pkg/agentic/transport.go
View file

@ -223,6 +223,9 @@ func mcpInitializeResult(ctx context.Context, url, token string) core.Result {
}
sessionID := response.Header.Get("Mcp-Session-Id")
if sessionID == "" {
return core.Result{Value: core.E("mcpInitialize", "missing session id", nil), OK: false}
}
drainSSE(response)