From aee645268896c7e8f9fee073cfeb6471224c3a2b Mon Sep 17 00:00:00 2001 From: Virgil Date: Tue, 31 Mar 2026 05:49:11 +0000 Subject: [PATCH] fix(ax): remove leftover narrative comments Co-Authored-By: Virgil --- pkg/agentic/actions.go | 2 +- pkg/agentic/epic.go | 10 +--------- pkg/agentic/pid.go | 2 +- pkg/agentic/verify.go | 1 - pkg/agentic/watch.go | 1 - pkg/brain/direct.go | 2 -- pkg/runner/runner.go | 1 - pkg/setup/config.go | 2 -- 8 files changed, 3 insertions(+), 18 deletions(-) diff --git a/pkg/agentic/actions.go b/pkg/agentic/actions.go index c085e9f..56ce8f8 100644 --- a/pkg/agentic/actions.go +++ b/pkg/agentic/actions.go @@ -1,7 +1,7 @@ // SPDX-License-Identifier: EUPL-1.2 // c.Action("agentic.dispatch").Run(ctx, options) -// c.Actions() // all registered capabilities +// c.Actions() package agentic diff --git a/pkg/agentic/epic.go b/pkg/agentic/epic.go index 2c6108f..a55c137 100644 --- a/pkg/agentic/epic.go +++ b/pkg/agentic/epic.go @@ -62,7 +62,6 @@ func (s *PrepSubsystem) createEpic(ctx context.Context, callRequest *mcp.CallToo input.Template = "coding" } - // Ensure "agentic" label exists labels := input.Labels hasAgentic := false for _, l := range labels { @@ -75,20 +74,17 @@ func (s *PrepSubsystem) createEpic(ctx context.Context, callRequest *mcp.CallToo labels = append(labels, "agentic") } - // Get label IDs labelIDs := s.resolveLabelIDs(ctx, input.Org, input.Repo, labels) - // Step 1: Create child issues first (we need their numbers for the checklist) var children []ChildRef for _, task := range input.Tasks { child, err := s.createIssue(ctx, input.Org, input.Repo, task, "", labelIDs) if err != nil { - continue // Skip failed children, create what we can + continue } children = append(children, child) } - // Step 2: Build epic body with checklist body := core.NewBuilder() if input.Body != "" { body.WriteString(input.Body) @@ -99,7 +95,6 @@ func (s *PrepSubsystem) createEpic(ctx context.Context, callRequest *mcp.CallToo body.WriteString(core.Sprintf("- [ ] #%d %s\n", child.Number, child.Title)) } - // Step 3: Create epic issue epicLabels := append(labelIDs, s.resolveLabelIDs(ctx, input.Org, input.Repo, []string{"epic"})...) epic, err := s.createIssue(ctx, input.Org, input.Repo, input.Title, body.String(), epicLabels) if err != nil { @@ -113,7 +108,6 @@ func (s *PrepSubsystem) createEpic(ctx context.Context, callRequest *mcp.CallToo Children: children, } - // Step 4: Optionally dispatch agents to each child if input.Dispatch { for _, child := range children { _, _, err := s.dispatch(ctx, callRequest, DispatchInput{ @@ -171,7 +165,6 @@ func (s *PrepSubsystem) resolveLabelIDs(ctx context.Context, org, repo string, n return nil } - // Fetch existing labels url := core.Sprintf("%s/api/v1/repos/%s/%s/labels?limit=50", s.forgeURL, org, repo) httpResult := HTTPGet(ctx, url, s.forgeToken, "token") if !httpResult.OK { @@ -194,7 +187,6 @@ func (s *PrepSubsystem) resolveLabelIDs(ctx context.Context, org, repo string, n if id, ok := nameToID[name]; ok { ids = append(ids, id) } else { - // Create the label id := s.createLabel(ctx, org, repo, name) if id > 0 { ids = append(ids, id) diff --git a/pkg/agentic/pid.go b/pkg/agentic/pid.go index 913e4e4..859c020 100644 --- a/pkg/agentic/pid.go +++ b/pkg/agentic/pid.go @@ -8,7 +8,7 @@ import ( ) // alive := agentic.ProcessAlive(c, proc.ID, proc.Info().PID) -// alive := agentic.ProcessAlive(c, "", 12345) // legacy PID fallback +// alive := agentic.ProcessAlive(c, "", 12345) func ProcessAlive(c *core.Core, processID string, pid int) bool { service, ok := lookupProcessService(c) if !ok { diff --git a/pkg/agentic/verify.go b/pkg/agentic/verify.go index c40312d..82ef418 100644 --- a/pkg/agentic/verify.go +++ b/pkg/agentic/verify.go @@ -228,7 +228,6 @@ func (s *PrepSubsystem) runPHPTests(repoDir string) verifyResult { process := s.Core().Process() composerResult := process.RunIn(ctx, repoDir, "composer", "test", "--no-interaction") if !composerResult.OK { - // Try pest as fallback fallbackResult := process.RunIn(ctx, repoDir, "./vendor/bin/pest", "--no-interaction") if !fallbackResult.OK { return verifyResult{passed: false, testCmd: "none", output: "No PHP test runner found (composer test and vendor/bin/pest both unavailable)", exitCode: 1} diff --git a/pkg/agentic/watch.go b/pkg/agentic/watch.go index a7e9ea6..02b1450 100644 --- a/pkg/agentic/watch.go +++ b/pkg/agentic/watch.go @@ -79,7 +79,6 @@ func (s *PrepSubsystem) watch(ctx context.Context, request *mcp.CallToolRequest, progressCount := float64(0) total := float64(len(workspaceNames)) - // MCP tests and internal callers may not provide a full request envelope. progressToken := any(nil) if request != nil && request.Params != nil { progressToken = request.Params.GetProgressToken() diff --git a/pkg/brain/direct.go b/pkg/brain/direct.go index 19f29ca..b1cba16 100644 --- a/pkg/brain/direct.go +++ b/pkg/brain/direct.go @@ -73,7 +73,6 @@ func (s *DirectSubsystem) RegisterTools(server *mcp.Server) { Description: "Remove a memory from OpenBrain by ID.", }, s.forget) - // Agent messaging — direct, chronological, not semantic s.RegisterMessagingTools(server) } @@ -152,7 +151,6 @@ func (s *DirectSubsystem) recall(ctx context.Context, _ *mcp.CallToolRequest, in "query": input.Query, "top_k": input.TopK, } - // Only filter by agent_id if explicitly provided — shared brain by default if input.Filter.AgentID != "" { body["agent_id"] = input.Filter.AgentID } diff --git a/pkg/runner/runner.go b/pkg/runner/runner.go index cebc9dc..042238c 100644 --- a/pkg/runner/runner.go +++ b/pkg/runner/runner.go @@ -274,7 +274,6 @@ func (s *Service) actionDispatch(_ context.Context, options core.Options) core.R return core.Result{Value: core.E("runner.actionDispatch", core.Concat("queue at capacity: ", reason), nil), OK: false} } - // Reserve the slot immediately — before returning to agentic. workspaceName := core.Concat("pending/", repo) s.workspaces.Set(workspaceName, &WorkspaceStatus{ Status: "running", diff --git a/pkg/setup/config.go b/pkg/setup/config.go index f103703..5a32961 100644 --- a/pkg/setup/config.go +++ b/pkg/setup/config.go @@ -193,13 +193,11 @@ func parseGitRemote(remote string) string { return "" } - // HTTPS/HTTP URL — extract path after host if core.Contains(remote, "://") { schemeParts := core.SplitN(remote, "://", 2) if len(schemeParts) == 2 { rest := schemeParts[1] if pathSegments := core.Split(rest, "/"); len(pathSegments) > 1 { - // Skip host, take path pathStart := len(pathSegments[0]) + 1 if pathStart < len(rest) { return trimRemotePath(rest[pathStart:])