dev #15
No reviewers
Labels
No labels
needs-review
needs-review
needs-review
needs-review
needs-review
athena
athena-gemini
audit
clotho
clotho-gemini
codex
darbs-claude
security
wiki
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: core/agent#15
Loading…
Add table
Reference in a new issue
No description provided.
Delete branch "dev"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Replace separate go-io (coreio) and go-log (coreerr) packages with Core's built-in Fs and error/logging functions. This is the reference implementation for how all Core ecosystem packages should migrate. Changes: - coreio.Local.Read/Write/EnsureDir/Delete/IsFile → core.Fs methods - coreerr.E() → core.E(), coreerr.Info/Warn/Error → core.Info/Warn/Error - (value, error) return pattern → core.Result pattern (r.OK, r.Value) - go-io and go-log moved from direct to indirect deps in go.mod - Added AX usage-example comments on key public types - Added newFs("/") helper for unrestricted filesystem access Co-Authored-By: Virgil <virgil@lethean.io>Phase 1: go-io/go-log → core.Fs{}, core.E(), core.Error/Info/Warn Phase 2: strings/fmt → core.Contains, core.Sprintf, core.Split etc Phase 3: embed.FS → core.Mount/core.Embed, core.Extract Phase 4: cmd/main.go → core.Command(), c.Cli().Run(), no cli package All packages migrated: - pkg/lib (Codex): core.Mount, core.Extract, Result returns, AX comments - pkg/setup (Codex): core.Fs, core.E, fixed missing lib helpers - pkg/brain (Codex): Core primitives, AX comments - pkg/monitor (Codex): Core string/logging primitives - pkg/agentic (Codex): 20 files, Core primitives throughout - cmd/main.go: pure Core CLI, no fmt/log/filepath/strings/cli Remaining stdlib: path/filepath (Core doesn't wrap OS paths), fmt.Sscanf/strings.Map (no Core equivalent). Co-Authored-By: Virgil <virgil@lethean.io>Was skipping directories entirely (`if entry.IsDir() { continue }`), so .core/reference/ and its contents were never extracted. Replaced fs.ReadDir loop with fs.WalkDir to handle nested dirs. Added tests: CreatesFiles, CreatesSubdirectories, TemplateSubstitution. Co-Authored-By: Virgil <virgil@lethean.io>Move all tests from tests/ to package root for proper coverage. Fix Fs zero-value: path() and validatePath() default empty root to "/" so &Fs{} works without New(). New tests: PathGlob, PathIsAbs, CleanPath, Cli.SetOutput, ServiceShutdown, Core.Context, Fs zero-value, Fs protected delete, Command lifecycle with implementation, error formatting branches, PerformAsync completion/no-handler/after-shutdown, Extract with templates, Embed path traversal. Coverage: 76.9% → 82.3% (23 test files, 82 new test cases). Co-Authored-By: Virgil <virgil@lethean.io>Major simplification of the dispatch model: - Workspace dir: .core/workspace/{org}/{repo}/{pr|task|branch|tag}/ - Clone into repo/ (not src/), metadata in .meta/ - One of issue, pr, branch, or tag required for dispatch - All context (brain, consumers, git log, wiki, plan) assembled into prompt string — no TODO.md, PROMPT.md, CONTEXT.md files - Resume detection: skip clone if repo/.git exists - Default agent changed to codex - spawnAgent drops srcDir param, runs from repo/ - No --skip-git-repo-check (repo/ IS a git repo) - All downstream files: srcDir → repoDir Track PRs, not workspace iterations. Co-Authored-By: Virgil <virgil@lethean.io>