core/agent
8
0
Fork 0
Code Issues 5 Pull requests Projects Releases Packages Wiki Activity Actions
agent/pkg/agentic/queue_test.go
Snider d47946ff82 feat(agent/process): add Timeout + GracePeriod + KillGroup to dispatch (#540) 
Per RFC.pipeline.md "go-process Improvements Needed": hung agent
processes blocked dispatch slots forever. Now killed after configured
timeout, with SIGTERM-then-SIGKILL grace period and process-group kill
to prevent orphaned subprocesses.

Lands:
* pkg/agentic/dispatch.go — every c.Process().Run() that spawns an
  agent now passes Timeout (DispatchConfig.TimeoutMinutes, default 60),
  GracePeriod: 30s, KillGroup: true. Watchdog writes timeout-specific
  failure reason into workspace status.
* pkg/agentic/queue.go — DispatchConfig adds TimeoutMinutes int (YAML:
  timeout_minutes, default 60) so operators can tune per-deployment.
* dispatch_test.go — TestDispatch_Run_Bad_Timeout asserts slow process
  transitions to failed state with timeout reason
* queue_test.go — TestQueue_Config_Good_TimeoutDefault asserts default 60

Verified go-process exposes timeout/gracePeriod/killGroup option keys
in the local checkout — no BLOCKED sibling needed.

Plain go build blocked by unrelated go.work conflict + sibling go-ws
coreerr.Warn missing (out of allowlist); supervisor's clean workspace
build will catch any remaining compile.

Co-authored-by: Codex <noreply@openai.com>
Closes tasks.lthn.sh/view.php?id=540
2026-04-25 23:08:19 +01:00

232 lines
7.8 KiB
Go
Raw Blame History

// SPDX-License-Identifier: EUPL-1.2
package agentic
import (
core "dappco.re/go/core"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"testing"
)
func TestQueue_BaseAgent_Ugly_Empty(t *testing.T) {
assert.Equal(t, "", baseAgent(""))
}
func TestQueue_BaseAgent_Ugly_MultipleColons(t *testing.T) {
// SplitN with N=2 should only split on first colon
assert.Equal(t, "claude", baseAgent("claude:opus:extra"))
}
func TestQueue_DispatchConfig_Good_Defaults(t *testing.T) {
// loadAgentsConfig falls back to defaults when no config file exists
s := &PrepSubsystem{ServiceRuntime: core.NewServiceRuntime(testCore, AgentOptions{}), codePath: t.TempDir()}
t.Setenv("CORE_WORKSPACE", t.TempDir())
cfg := s.loadAgentsConfig()
assert.Equal(t, "claude", cfg.Dispatch.DefaultAgent)
assert.Equal(t, "coding", cfg.Dispatch.DefaultTemplate)
assert.Equal(t, 60, cfg.Dispatch.TimeoutMinutes)
assert.Equal(t, 1, cfg.Concurrency["claude"].Total)
assert.Equal(t, 3, cfg.Concurrency["gemini"].Total)
}
func TestQueue_Config_Good_TimeoutDefault(t *testing.T) {
root := t.TempDir()
setTestWorkspace(t, root)
require.True(t, fs.Write(core.JoinPath(root, "agents.yaml"), "version: 1\ndispatch:\n default_agent: codex\n").OK)
t.Cleanup(func() { setWorkspaceRootOverride("") })
s := &PrepSubsystem{ServiceRuntime: core.NewServiceRuntime(testCore, AgentOptions{}), codePath: t.TempDir()}
cfg := s.loadAgentsConfig()
assert.Equal(t, 60, cfg.Dispatch.TimeoutMinutes)
}
func TestQueue_DispatchConfig_Good_RuntimeImageGPUFromYAML(t *testing.T) {
root := t.TempDir()
setTestWorkspace(t, root)
require.True(t, fs.Write(core.JoinPath(root, "agents.yaml"), core.Concat(
"version: 1\n",
"dispatch:\n",
" runtime: apple\n",
" image: core-ml\n",
" gpu: true\n",
" timeout_minutes: 45\n",
)).OK)
t.Cleanup(func() {
setWorkspaceRootOverride("")
})
s := &PrepSubsystem{ServiceRuntime: core.NewServiceRuntime(testCore, AgentOptions{}), codePath: t.TempDir()}
cfg := s.loadAgentsConfig()
assert.Equal(t, "apple", cfg.Dispatch.Runtime)
assert.Equal(t, "core-ml", cfg.Dispatch.Image)
assert.True(t, cfg.Dispatch.GPU)
assert.Equal(t, 45, cfg.Dispatch.TimeoutMinutes)
}
func TestQueue_DispatchConfig_Bad_OmittedRuntimeFields(t *testing.T) {
root := t.TempDir()
setTestWorkspace(t, root)
require.True(t, fs.Write(core.JoinPath(root, "agents.yaml"), "version: 1\ndispatch:\n default_agent: codex\n").OK)
t.Cleanup(func() { setWorkspaceRootOverride("") })
s := &PrepSubsystem{ServiceRuntime: core.NewServiceRuntime(testCore, AgentOptions{}), codePath: t.TempDir()}
cfg := s.loadAgentsConfig()
assert.Empty(t, cfg.Dispatch.Runtime)
assert.Empty(t, cfg.Dispatch.Image)
assert.False(t, cfg.Dispatch.GPU)
}
func TestQueue_DispatchConfig_Ugly_PartialRuntimeBlock(t *testing.T) {
root := t.TempDir()
setTestWorkspace(t, root)
require.True(t, fs.Write(core.JoinPath(root, "agents.yaml"), "version: 1\ndispatch:\n runtime: docker\n").OK)
t.Cleanup(func() { setWorkspaceRootOverride("") })
s := &PrepSubsystem{ServiceRuntime: core.NewServiceRuntime(testCore, AgentOptions{}), codePath: t.TempDir()}
cfg := s.loadAgentsConfig()
assert.Equal(t, "docker", cfg.Dispatch.Runtime)
assert.Empty(t, cfg.Dispatch.Image)
assert.False(t, cfg.Dispatch.GPU)
}
// --- AgentIdentity ---
func TestQueue_AgentIdentity_Good_FullParseFromYAML(t *testing.T) {
root := t.TempDir()
setTestWorkspace(t, root)
require.True(t, fs.Write(core.JoinPath(root, "agents.yaml"), core.Concat(
"version: 1\n",
"agents:\n",
" cladius:\n",
" host: local\n",
" runner: claude\n",
" active: true\n",
" roles: [dispatch, review, plan]\n",
" codex:\n",
" host: cloud\n",
" runner: openai\n",
" active: true\n",
" roles: [worker]\n",
)).OK)
t.Cleanup(func() { setWorkspaceRootOverride("") })
s := &PrepSubsystem{ServiceRuntime: core.NewServiceRuntime(testCore, AgentOptions{}), codePath: t.TempDir()}
cfg := s.loadAgentsConfig()
assert.Equal(t, "local", cfg.Agents["cladius"].Host)
assert.Equal(t, "claude", cfg.Agents["cladius"].Runner)
assert.True(t, cfg.Agents["cladius"].Active)
assert.Contains(t, cfg.Agents["cladius"].Roles, "dispatch")
assert.Equal(t, "cloud", cfg.Agents["codex"].Host)
}
func TestQueue_AgentIdentity_Bad_MissingAgentsBlock(t *testing.T) {
root := t.TempDir()
setTestWorkspace(t, root)
require.True(t, fs.Write(core.JoinPath(root, "agents.yaml"), "version: 1\n").OK)
t.Cleanup(func() { setWorkspaceRootOverride("") })
s := &PrepSubsystem{ServiceRuntime: core.NewServiceRuntime(testCore, AgentOptions{}), codePath: t.TempDir()}
cfg := s.loadAgentsConfig()
assert.Empty(t, cfg.Agents)
}
func TestQueue_AgentIdentity_Ugly_OnlyHostSet(t *testing.T) {
root := t.TempDir()
setTestWorkspace(t, root)
require.True(t, fs.Write(core.JoinPath(root, "agents.yaml"), core.Concat(
"agents:\n",
" ghost:\n",
" host: 192.168.0.42\n",
)).OK)
t.Cleanup(func() { setWorkspaceRootOverride("") })
s := &PrepSubsystem{ServiceRuntime: core.NewServiceRuntime(testCore, AgentOptions{}), codePath: t.TempDir()}
cfg := s.loadAgentsConfig()
assert.Equal(t, "192.168.0.42", cfg.Agents["ghost"].Host)
assert.Empty(t, cfg.Agents["ghost"].Runner)
assert.False(t, cfg.Agents["ghost"].Active)
}
func TestQueue_DispatchConfig_Good_WorkspaceRootOverride(t *testing.T) {
root := t.TempDir()
setTestWorkspace(t, root)
customRoot := core.JoinPath(root, "agent-workspaces")
require.True(t, fs.Write(core.JoinPath(root, "agents.yaml"), core.Concat(
"version: 1\n",
"dispatch:\n",
" workspace_root: ", customRoot, "\n",
)).OK)
t.Cleanup(func() {
setWorkspaceRootOverride("")
})
s := &PrepSubsystem{ServiceRuntime: core.NewServiceRuntime(testCore, AgentOptions{}), codePath: t.TempDir()}
cfg := s.loadAgentsConfig()
assert.Equal(t, customRoot, cfg.Dispatch.WorkspaceRoot)
assert.Equal(t, customRoot, WorkspaceRoot())
}
func TestQueue_CanDispatchAgent_Good_NoConfig(t *testing.T) {
// With no running workspaces and default config, should be able to dispatch
root := t.TempDir()
setTestWorkspace(t, root)
require.True(t, fs.EnsureDir(core.JoinPath(root, "workspace")).OK)
s := &PrepSubsystem{ServiceRuntime: core.NewServiceRuntime(testCore, AgentOptions{}), codePath: t.TempDir()}
assert.True(t, s.canDispatchAgent("gemini"))
}
func TestQueue_CanDispatchAgent_Good_UnknownAgent(t *testing.T) {
// Unknown agent has no limit, so always allowed
root := t.TempDir()
setTestWorkspace(t, root)
require.True(t, fs.EnsureDir(core.JoinPath(root, "workspace")).OK)
s := &PrepSubsystem{ServiceRuntime: core.NewServiceRuntime(testCore, AgentOptions{}), codePath: t.TempDir()}
assert.True(t, s.canDispatchAgent("unknown-agent"))
}
func TestQueue_CountRunningByAgent_Good_EmptyWorkspace(t *testing.T) {
root := t.TempDir()
setTestWorkspace(t, root)
require.True(t, fs.EnsureDir(core.JoinPath(root, "workspace")).OK)
s := &PrepSubsystem{ServiceRuntime: core.NewServiceRuntime(testCore, AgentOptions{})}
assert.Equal(t, 0, s.countRunningByAgent("gemini"))
assert.Equal(t, 0, s.countRunningByAgent("claude"))
}
func TestQueue_CountRunningByAgent_Good_NoRunning(t *testing.T) {
root := t.TempDir()
setTestWorkspace(t, root)
// Create a workspace with completed status under workspace/
ws := core.JoinPath(root, "workspace", "test-ws")
require.True(t, fs.EnsureDir(ws).OK)
require.NoError(t, writeStatus(ws, &WorkspaceStatus{
Status: "completed",
Agent: "gemini",
PID: 0,
}))
s := &PrepSubsystem{ServiceRuntime: core.NewServiceRuntime(testCore, AgentOptions{})}
assert.Equal(t, 0, s.countRunningByAgent("gemini"))
}
func TestQueue_DelayForAgent_Good_NoConfig(t *testing.T) {
// With no config, delay should be 0
t.Setenv("CORE_WORKSPACE", t.TempDir())
s := &PrepSubsystem{ServiceRuntime: core.NewServiceRuntime(testCore, AgentOptions{}), codePath: t.TempDir()}
assert.Equal(t, 0, int(s.delayForAgent("gemini").Seconds()))
}
Reference in a new issue View git blame Copy permalink