537226bd4d
AX Quality Gates (RFC-025):
- Eliminate os/exec from all test + production code (12+ files)
- Eliminate encoding/json from all test files (15 files, 66 occurrences)
- Eliminate os from all test files except TestMain (Go runtime contract)
- Eliminate path/filepath, net/url from all files
- String concat: 39 violations replaced with core.Concat()
- Test naming AX-7: 264 test functions renamed across all 6 packages
- Example test 1:1 coverage complete
Core Features Adopted:
- Task Composition: agent.completion pipeline (QA → PR → Verify → Ingest → Poke)
- PerformAsync: completion pipeline runs with WaitGroup + progress tracking
- Config: agents.yaml loaded once, feature flags (auto-qa/pr/merge/ingest)
- Named Locks: c.Lock("drain") for queue serialisation
- Registry: workspace state with cross-package QUERY access
- QUERY: c.QUERY(WorkspaceQuery{Status: "running"}) for cross-service queries
- Action descriptions: 25+ Actions self-documenting
- Data mounts: prompts/tasks/flows/personas/workspaces via c.Data()
- Content Actions: agentic.prompt/task/flow/persona callable via IPC
- Drive endpoints: forge + brain registered with tokens
- Drive REST helpers: DriveGet/DrivePost/DriveDo for Drive-aware HTTP
- HandleIPCEvents: auto-discovered by WithService (no manual wiring)
- Entitlement: frozen-queue gate on write Actions
- CLI dispatch: workspace dispatch wired to real dispatch method
- CLI: --quiet/-q and --debug/-d global flags
- CLI: banner, version, check (with service/action/command counts), env
- main.go: minimal — 5 services + c.Run(), no os import
- cmd tests: 84.2% coverage (was 0%)
Co-Authored-By: Virgil <virgil@lethean.io>
85 lines
3 KiB
Go
85 lines
3 KiB
Go
// SPDX-License-Identifier: EUPL-1.2
|
|
|
|
package agentic
|
|
|
|
import (
|
|
core "dappco.re/go/core"
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
"testing"
|
|
)
|
|
|
|
func TestQueue_BaseAgent_Ugly_Empty(t *testing.T) {
|
|
assert.Equal(t, "", baseAgent(""))
|
|
}
|
|
|
|
func TestQueue_BaseAgent_Ugly_MultipleColons(t *testing.T) {
|
|
// SplitN with N=2 should only split on first colon
|
|
assert.Equal(t, "claude", baseAgent("claude:opus:extra"))
|
|
}
|
|
|
|
func TestQueue_DispatchConfig_Good_Defaults(t *testing.T) {
|
|
// loadAgentsConfig falls back to defaults when no config file exists
|
|
s := &PrepSubsystem{ServiceRuntime: core.NewServiceRuntime(testCore, AgentOptions{}), codePath: t.TempDir()}
|
|
t.Setenv("CORE_WORKSPACE", t.TempDir())
|
|
|
|
cfg := s.loadAgentsConfig()
|
|
assert.Equal(t, "claude", cfg.Dispatch.DefaultAgent)
|
|
assert.Equal(t, "coding", cfg.Dispatch.DefaultTemplate)
|
|
assert.Equal(t, 1, cfg.Concurrency["claude"].Total)
|
|
assert.Equal(t, 3, cfg.Concurrency["gemini"].Total)
|
|
}
|
|
|
|
func TestQueue_CanDispatchAgent_Good_NoConfig(t *testing.T) {
|
|
// With no running workspaces and default config, should be able to dispatch
|
|
root := t.TempDir()
|
|
t.Setenv("CORE_WORKSPACE", root)
|
|
require.True(t, fs.EnsureDir(core.JoinPath(root, "workspace")).OK)
|
|
|
|
s := &PrepSubsystem{ServiceRuntime: core.NewServiceRuntime(testCore, AgentOptions{}), codePath: t.TempDir()}
|
|
assert.True(t, s.canDispatchAgent("gemini"))
|
|
}
|
|
|
|
func TestQueue_CanDispatchAgent_Good_UnknownAgent(t *testing.T) {
|
|
// Unknown agent has no limit, so always allowed
|
|
root := t.TempDir()
|
|
t.Setenv("CORE_WORKSPACE", root)
|
|
require.True(t, fs.EnsureDir(core.JoinPath(root, "workspace")).OK)
|
|
|
|
s := &PrepSubsystem{ServiceRuntime: core.NewServiceRuntime(testCore, AgentOptions{}), codePath: t.TempDir()}
|
|
assert.True(t, s.canDispatchAgent("unknown-agent"))
|
|
}
|
|
|
|
func TestQueue_CountRunningByAgent_Good_EmptyWorkspace(t *testing.T) {
|
|
root := t.TempDir()
|
|
t.Setenv("CORE_WORKSPACE", root)
|
|
require.True(t, fs.EnsureDir(core.JoinPath(root, "workspace")).OK)
|
|
|
|
s := &PrepSubsystem{ServiceRuntime: core.NewServiceRuntime(testCore, AgentOptions{})}
|
|
assert.Equal(t, 0, s.countRunningByAgent("gemini"))
|
|
assert.Equal(t, 0, s.countRunningByAgent("claude"))
|
|
}
|
|
|
|
func TestQueue_CountRunningByAgent_Good_NoRunning(t *testing.T) {
|
|
root := t.TempDir()
|
|
t.Setenv("CORE_WORKSPACE", root)
|
|
|
|
// Create a workspace with completed status under workspace/
|
|
ws := core.JoinPath(root, "workspace", "test-ws")
|
|
require.True(t, fs.EnsureDir(ws).OK)
|
|
require.NoError(t, writeStatus(ws, &WorkspaceStatus{
|
|
Status: "completed",
|
|
Agent: "gemini",
|
|
PID: 0,
|
|
}))
|
|
|
|
s := &PrepSubsystem{ServiceRuntime: core.NewServiceRuntime(testCore, AgentOptions{})}
|
|
assert.Equal(t, 0, s.countRunningByAgent("gemini"))
|
|
}
|
|
|
|
func TestQueue_DelayForAgent_Good_NoConfig(t *testing.T) {
|
|
// With no config, delay should be 0
|
|
t.Setenv("CORE_WORKSPACE", t.TempDir())
|
|
s := &PrepSubsystem{ServiceRuntime: core.NewServiceRuntime(testCore, AgentOptions{}), codePath: t.TempDir()}
|
|
assert.Equal(t, 0, int(s.delayForAgent("gemini").Seconds()))
|
|
}
|