AX Quality Gates (RFC-025):
- Eliminate os/exec from all test + production code (12+ files)
- Eliminate encoding/json from all test files (15 files, 66 occurrences)
- Eliminate os from all test files except TestMain (Go runtime contract)
- Eliminate path/filepath, net/url from all files
- String concat: 39 violations replaced with core.Concat()
- Test naming AX-7: 264 test functions renamed across all 6 packages
- Example test 1:1 coverage complete
Core Features Adopted:
- Task Composition: agent.completion pipeline (QA → PR → Verify → Ingest → Poke)
- PerformAsync: completion pipeline runs with WaitGroup + progress tracking
- Config: agents.yaml loaded once, feature flags (auto-qa/pr/merge/ingest)
- Named Locks: c.Lock("drain") for queue serialisation
- Registry: workspace state with cross-package QUERY access
- QUERY: c.QUERY(WorkspaceQuery{Status: "running"}) for cross-service queries
- Action descriptions: 25+ Actions self-documenting
- Data mounts: prompts/tasks/flows/personas/workspaces via c.Data()
- Content Actions: agentic.prompt/task/flow/persona callable via IPC
- Drive endpoints: forge + brain registered with tokens
- Drive REST helpers: DriveGet/DrivePost/DriveDo for Drive-aware HTTP
- HandleIPCEvents: auto-discovered by WithService (no manual wiring)
- Entitlement: frozen-queue gate on write Actions
- CLI dispatch: workspace dispatch wired to real dispatch method
- CLI: --quiet/-q and --debug/-d global flags
- CLI: banner, version, check (with service/action/command counts), env
- main.go: minimal — 5 services + c.Run(), no os import
- cmd tests: 84.2% coverage (was 0%)
Co-Authored-By: Virgil <virgil@lethean.io>
140 lines
4.2 KiB
Go
140 lines
4.2 KiB
Go
// SPDX-License-Identifier: EUPL-1.2
|
|
|
|
package brain
|
|
|
|
import (
|
|
"bytes"
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"testing"
|
|
|
|
core "dappco.re/go/core"
|
|
"github.com/gin-gonic/gin"
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func init() {
|
|
gin.SetMode(gin.TestMode)
|
|
}
|
|
|
|
// setupRouter creates a gin engine with provider routes registered.
|
|
func setupRouter(p *BrainProvider) *gin.Engine {
|
|
r := gin.New()
|
|
g := r.Group(p.BasePath())
|
|
p.RegisterRoutes(g)
|
|
return r
|
|
}
|
|
|
|
// providerRequest performs an HTTP request against the provider router and returns the recorder.
|
|
func providerRequest(t *testing.T, p *BrainProvider, method, path string, body []byte) *httptest.ResponseRecorder {
|
|
t.Helper()
|
|
r := setupRouter(p)
|
|
w := httptest.NewRecorder()
|
|
var req *http.Request
|
|
if body != nil {
|
|
req, _ = http.NewRequest(method, path, bytes.NewReader(body))
|
|
req.Header.Set("Content-Type", "application/json")
|
|
} else {
|
|
req, _ = http.NewRequest(method, path, nil)
|
|
}
|
|
r.ServeHTTP(w, req)
|
|
return w
|
|
}
|
|
|
|
// --- Provider construction ---
|
|
|
|
func TestProvider_NewProvider_Good(t *testing.T) {
|
|
p := NewProvider(nil, nil)
|
|
assert.NotNil(t, p)
|
|
assert.Nil(t, p.bridge)
|
|
assert.Nil(t, p.hub)
|
|
}
|
|
|
|
func TestProvider_BrainProvider_Good_Name(t *testing.T) {
|
|
assert.Equal(t, "brain", NewProvider(nil, nil).Name())
|
|
}
|
|
|
|
func TestProvider_BrainProvider_Good_BasePath(t *testing.T) {
|
|
assert.Equal(t, "/api/brain", NewProvider(nil, nil).BasePath())
|
|
}
|
|
|
|
func TestProvider_BrainProvider_Good_Channels(t *testing.T) {
|
|
channels := NewProvider(nil, nil).Channels()
|
|
assert.Len(t, channels, 3)
|
|
assert.Contains(t, channels, "brain.remember.complete")
|
|
assert.Contains(t, channels, "brain.recall.complete")
|
|
assert.Contains(t, channels, "brain.forget.complete")
|
|
}
|
|
|
|
func TestProvider_BrainProvider_Good_Element(t *testing.T) {
|
|
el := NewProvider(nil, nil).Element()
|
|
assert.Equal(t, "core-brain-panel", el.Tag)
|
|
assert.Equal(t, "/assets/brain-panel.js", el.Source)
|
|
}
|
|
|
|
func TestProvider_BrainProvider_Good_Describe(t *testing.T) {
|
|
descs := NewProvider(nil, nil).Describe()
|
|
assert.Len(t, descs, 5)
|
|
|
|
paths := make([]string, len(descs))
|
|
for i, d := range descs {
|
|
paths[i] = d.Method + " " + d.Path
|
|
}
|
|
assert.Contains(t, paths, "POST /remember")
|
|
assert.Contains(t, paths, "POST /recall")
|
|
assert.Contains(t, paths, "POST /forget")
|
|
assert.Contains(t, paths, "GET /list")
|
|
assert.Contains(t, paths, "GET /status")
|
|
}
|
|
|
|
// --- Handler: status ---
|
|
|
|
func TestProvider_Status_Good(t *testing.T) {
|
|
p := NewProvider(nil, nil)
|
|
w := providerRequest(t, p, "GET", "/api/brain/status", nil)
|
|
|
|
assert.Equal(t, http.StatusOK, w.Code)
|
|
var resp map[string]any
|
|
require.True(t, core.JSONUnmarshal(w.Body.Bytes(), &resp).OK)
|
|
data, _ := resp["data"].(map[string]any)
|
|
assert.Equal(t, false, data["connected"])
|
|
}
|
|
|
|
// --- Nil bridge handlers return 503 ---
|
|
|
|
func TestProvider_RememberHandler_Bad(t *testing.T) {
|
|
body := []byte(core.JSONMarshalString(map[string]any{"content": "test memory", "type": "observation"}))
|
|
w := providerRequest(t, NewProvider(nil, nil), "POST", "/api/brain/remember", body)
|
|
assert.Equal(t, http.StatusServiceUnavailable, w.Code)
|
|
}
|
|
|
|
func TestProvider_RememberHandlerInvalid_Bad(t *testing.T) {
|
|
// nil bridge returns 503 before JSON validation.
|
|
w := providerRequest(t, NewProvider(nil, nil), "POST", "/api/brain/remember", []byte("not json"))
|
|
assert.Equal(t, http.StatusServiceUnavailable, w.Code)
|
|
}
|
|
|
|
func TestProvider_RecallHandler_Bad(t *testing.T) {
|
|
body := []byte(core.JSONMarshalString(map[string]any{"query": "test"}))
|
|
w := providerRequest(t, NewProvider(nil, nil), "POST", "/api/brain/recall", body)
|
|
assert.Equal(t, http.StatusServiceUnavailable, w.Code)
|
|
}
|
|
|
|
func TestProvider_ForgetHandler_Bad(t *testing.T) {
|
|
body := []byte(core.JSONMarshalString(map[string]any{"id": "mem-123"}))
|
|
w := providerRequest(t, NewProvider(nil, nil), "POST", "/api/brain/forget", body)
|
|
assert.Equal(t, http.StatusServiceUnavailable, w.Code)
|
|
}
|
|
|
|
func TestProvider_ListHandler_Bad(t *testing.T) {
|
|
w := providerRequest(t, NewProvider(nil, nil), "GET", "/api/brain/list", nil)
|
|
assert.Equal(t, http.StatusServiceUnavailable, w.Code)
|
|
}
|
|
|
|
// --- emitEvent ---
|
|
|
|
func TestProvider_EmitEvent_Good(t *testing.T) {
|
|
p := NewProvider(nil, nil)
|
|
p.emitEvent("brain.test", map[string]any{"foo": "bar"})
|
|
}
|