6832d40587
Codex 5.5 batch lane processed 8 brain Mantis tickets. 4 implemented, 1 stale, 3 deferred. Tickets implemented: - #313 — MCP schemas (BrainRemember/Recall/List): org field maxLength=128 with runtime validation; recall filter.org also bounded; pest test coverage added - #314 — BrainList: removed withCircuitBreaker('brain') from DB-only handler; CircuitBreakerTest updated to assert no breaker call - #315 — BrainService.retryableHttp(): now retries 408 (request-timeout), 429 (rate-limit), and 5xx; honours Retry-After header; focused retry tests added - #326 — BrainService.forget(): dispatches DeleteFromIndex only when row has indexed_at (was unconditional); SupersedeForgetIndexCleanupTest covers never-indexed case Tickets stale-fixed: #316 (RememberKnowledge already rejects missing/deleted supersedes target before dangling retry) Tickets deferred: #121 (cross-surface audit), #311 (retry-inside-breaker architectural redesign), #312 (no authoritative org claim in MCP request context yet) Co-authored-by: Codex <noreply@openai.com> Closes tasks.lthn.sh/view.php?id=313 Closes tasks.lthn.sh/view.php?id=314 Closes tasks.lthn.sh/view.php?id=315 Closes tasks.lthn.sh/view.php?id=326
109 lines
3.9 KiB
PHP
109 lines
3.9 KiB
PHP
<?php
|
|
|
|
// SPDX-License-Identifier: EUPL-1.2
|
|
|
|
declare(strict_types=1);
|
|
|
|
use Core\Mod\Agentic\Jobs\DeleteFromIndex;
|
|
use Core\Mod\Agentic\Jobs\EmbedMemory;
|
|
use Core\Mod\Agentic\Models\BrainMemory;
|
|
use Core\Mod\Agentic\Services\BrainService;
|
|
use Illuminate\Support\Facades\Queue;
|
|
|
|
function cleanupBrainService(): BrainService
|
|
{
|
|
return new BrainService;
|
|
}
|
|
|
|
function cleanupMemory(array $attributes = []): BrainMemory
|
|
{
|
|
return BrainMemory::create(array_merge([
|
|
'workspace_id' => $attributes['workspace_id'] ?? createWorkspace()->id,
|
|
'agent_id' => 'virgil',
|
|
'type' => 'observation',
|
|
'content' => 'Brain cleanup test memory.',
|
|
'confidence' => 0.84,
|
|
'org' => 'core',
|
|
'project' => 'agent',
|
|
], $attributes));
|
|
}
|
|
|
|
test('SupersedeForgetIndexCleanup_forget_Good_dispatches_delete_from_index', function (): void {
|
|
Queue::fake();
|
|
$memory = cleanupMemory(['indexed_at' => now()]);
|
|
|
|
cleanupBrainService()->forget($memory->id);
|
|
|
|
expect(BrainMemory::find($memory->id))->toBeNull()
|
|
->and(BrainMemory::withTrashed()->find($memory->id)?->trashed())->toBeTrue();
|
|
|
|
Queue::assertPushed(DeleteFromIndex::class, fn (DeleteFromIndex $job): bool => $job->memoryId === $memory->id);
|
|
});
|
|
|
|
test('SupersedeForgetIndexCleanup_forget_Bad_skips_delete_from_index_for_never_indexed_memory', function (): void {
|
|
Queue::fake();
|
|
$memory = cleanupMemory(['indexed_at' => null]);
|
|
|
|
cleanupBrainService()->forget($memory->id);
|
|
|
|
expect(BrainMemory::find($memory->id))->toBeNull()
|
|
->and(BrainMemory::withTrashed()->find($memory->id)?->trashed())->toBeTrue();
|
|
|
|
Queue::assertNotPushed(DeleteFromIndex::class, fn (DeleteFromIndex $job): bool => $job->memoryId === $memory->id);
|
|
});
|
|
|
|
test('SupersedeForgetIndexCleanup_supersede_Bad_dispatches_cleanup_for_old_indexed_memory', function (): void {
|
|
Queue::fake();
|
|
$workspace = createWorkspace();
|
|
$oldMemory = cleanupMemory([
|
|
'workspace_id' => $workspace->id,
|
|
'content' => 'Old indexed memory.',
|
|
'indexed_at' => now(),
|
|
]);
|
|
|
|
$newMemory = cleanupBrainService()->remember([
|
|
'workspace_id' => $workspace->id,
|
|
'agent_id' => 'virgil',
|
|
'type' => 'observation',
|
|
'content' => 'New superseding memory.',
|
|
'confidence' => 0.93,
|
|
'org' => 'core',
|
|
'project' => 'agent',
|
|
'supersedes_id' => $oldMemory->id,
|
|
]);
|
|
|
|
expect(BrainMemory::find($oldMemory->id))->toBeNull()
|
|
->and(BrainMemory::withTrashed()->find($oldMemory->id)?->trashed())->toBeTrue()
|
|
->and($newMemory->indexed_at)->toBeNull();
|
|
|
|
Queue::assertPushed(DeleteFromIndex::class, fn (DeleteFromIndex $job): bool => $job->memoryId === $oldMemory->id);
|
|
Queue::assertPushed(EmbedMemory::class, fn (EmbedMemory $job): bool => $job->memoryId === $newMemory->id);
|
|
});
|
|
|
|
test('SupersedeForgetIndexCleanup_supersede_Ugly_skips_cleanup_for_never_indexed_memory', function (): void {
|
|
Queue::fake();
|
|
$workspace = createWorkspace();
|
|
$oldMemory = cleanupMemory([
|
|
'workspace_id' => $workspace->id,
|
|
'content' => 'Old unindexed memory.',
|
|
'indexed_at' => null,
|
|
]);
|
|
|
|
$newMemory = cleanupBrainService()->remember([
|
|
'workspace_id' => $workspace->id,
|
|
'agent_id' => 'virgil',
|
|
'type' => 'observation',
|
|
'content' => 'Superseding unindexed memory.',
|
|
'confidence' => 0.9,
|
|
'org' => 'core',
|
|
'project' => 'agent',
|
|
'supersedes_id' => $oldMemory->id,
|
|
]);
|
|
|
|
expect(BrainMemory::find($oldMemory->id))->toBeNull()
|
|
->and(BrainMemory::withTrashed()->find($oldMemory->id)?->trashed())->toBeTrue()
|
|
->and($newMemory->indexed_at)->toBeNull();
|
|
|
|
Queue::assertNotPushed(DeleteFromIndex::class, fn (DeleteFromIndex $job): bool => $job->memoryId === $oldMemory->id);
|
|
Queue::assertPushed(EmbedMemory::class, fn (EmbedMemory $job): bool => $job->memoryId === $newMemory->id);
|
|
});
|