20+ CHANGES_REQUESTED dispositions across PHP MCP services, Go pkg/agentic, hermes_runner_mcp Python server, plugin shell scripts. Highlights: - DatabaseSchema.php: identifier quoting - AwardCredits.php: task row locking order - CreditTransaction.php: fail-fast row decoding - OpenApiGenerator.php: YAML parse handling + uri query params - CaptureDispatchResultJob.php: AgentProfile namespace fix - CreditsController.php: missing workspace_id fail-closed - QueryAuditService.php: prose query false positives + unbounded aggregation - McpHealthService.php: proc_close after timeout + env var resolution - CreditLedger.php + FleetOverview.php: workspace agent + dispatch target validation - McpAgentServerCommand.php: quota burn on failed tool calls - McpMetricsService.php: N-day window consistency - hermes_runner_mcp: API key off command line + invalid method+id + run_id encoding - CircuitBreaker.php: extracted CircuitOpenException class with autoload-correct placement - pkg/agentic + brain + flow: SonarCloud sendMessage/fetchLoopRepoRefs/commitWorkspace/Connect annotations - shell scripts: removed [[ usage for portability 43 files modified, 1 new (CircuitOpenException.php). Verification: gofmt -w + php -l + python3 -m py_compile + bash -n all clean. Touched-package go test passes (pkg/lib/flow, pkg/lib). Full go test ./... blocked by pre-existing dappco.re module graph drift, out of scope. Parked for separate work: - Mantis #1062: go.mod local replace removal (cross-repo architectural) - Mantis #1063: Sonar residual line-length / duplication quality-gate cluster Closes findings on https://github.com/dAppCore/agent/pull/6 Co-authored-by: Codex <noreply@openai.com>
121 lines
3.8 KiB
PHP
121 lines
3.8 KiB
PHP
<?php
|
|
|
|
// SPDX-License-Identifier: EUPL-1.2
|
|
|
|
declare(strict_types=1);
|
|
|
|
namespace Core\Mod\Agentic\Actions\Brain;
|
|
|
|
use Core\Actions\Action;
|
|
use Core\Mod\Agentic\Models\BrainMemory;
|
|
use Core\Mod\Agentic\Services\BrainService;
|
|
|
|
/**
|
|
* Store a memory in the shared OpenBrain knowledge store.
|
|
*
|
|
* Persists content with embeddings to both MariaDB and Qdrant.
|
|
* Handles supersession (replacing old memories) and expiry.
|
|
*
|
|
* Usage:
|
|
* $memory = RememberKnowledge::run($data, 1, 'virgil');
|
|
*/
|
|
class RememberKnowledge
|
|
{
|
|
use Action;
|
|
|
|
public function __construct(
|
|
private BrainService $brain,
|
|
) {}
|
|
|
|
/**
|
|
* @param array{
|
|
* content: string,
|
|
* type: string,
|
|
* tags?: array,
|
|
* org?: string,
|
|
* project?: string,
|
|
* confidence?: float,
|
|
* supersedes?: string,
|
|
* expires_in?: int
|
|
* } $data
|
|
* @return BrainMemory The created memory
|
|
*
|
|
* @throws \InvalidArgumentException
|
|
* @throws \RuntimeException
|
|
*/
|
|
public function handle(array $data, int $workspaceId, string $agentId = 'anonymous'): BrainMemory
|
|
{
|
|
$content = $data['content'] ?? null;
|
|
if (! is_string($content) || $content === '') {
|
|
throw new \InvalidArgumentException('content is required and must be a non-empty string');
|
|
}
|
|
if (mb_strlen($content) > 50000) {
|
|
throw new \InvalidArgumentException('content must not exceed 50,000 characters');
|
|
}
|
|
|
|
$type = $data['type'] ?? null;
|
|
if (! is_string($type) || ! in_array($type, BrainMemory::VALID_TYPES, true)) {
|
|
throw new \InvalidArgumentException(
|
|
sprintf(
|
|
'type must be one of: %s',
|
|
implode(', ', BrainMemory::VALID_TYPES),
|
|
)
|
|
);
|
|
}
|
|
|
|
$confidence = (float) ($data['confidence'] ?? 0.8);
|
|
if ($confidence < 0.0 || $confidence > 1.0) {
|
|
throw new \InvalidArgumentException('confidence must be between 0.0 and 1.0');
|
|
}
|
|
|
|
$tags = $data['tags'] ?? null;
|
|
if (is_array($tags)) {
|
|
foreach ($tags as $tag) {
|
|
if (! is_string($tag)) {
|
|
throw new \InvalidArgumentException('Each tag must be a string');
|
|
}
|
|
}
|
|
}
|
|
|
|
$supersedes = $data['supersedes'] ?? null;
|
|
if ($supersedes !== null) {
|
|
$existing = BrainMemory::where('id', $supersedes)
|
|
->where('workspace_id', $workspaceId)
|
|
->first();
|
|
|
|
if (! $existing) {
|
|
throw new \InvalidArgumentException("Memory '{$supersedes}' not found in this workspace");
|
|
}
|
|
}
|
|
|
|
$expiresIn = isset($data['expires_in']) ? (int) $data['expires_in'] : null;
|
|
if ($expiresIn !== null && $expiresIn < 1) {
|
|
throw new \InvalidArgumentException('expires_in must be at least 1 hour');
|
|
}
|
|
|
|
$org = $data['org'] ?? null;
|
|
if ($org !== null) {
|
|
if (! is_string($org) || trim($org) === '') {
|
|
throw new \InvalidArgumentException('org must be a non-empty string when provided');
|
|
}
|
|
|
|
$org = trim($org);
|
|
if (mb_strlen($org) > 128) {
|
|
throw new \InvalidArgumentException('org must not exceed 128 characters');
|
|
}
|
|
}
|
|
|
|
return $this->brain->remember([
|
|
'workspace_id' => $workspaceId,
|
|
'agent_id' => $agentId,
|
|
'type' => $type,
|
|
'content' => $content,
|
|
'tags' => $tags,
|
|
'org' => $org,
|
|
'project' => $data['project'] ?? null,
|
|
'confidence' => $confidence,
|
|
'supersedes_id' => $supersedes,
|
|
'expires_at' => $expiresIn ? now()->addHours($expiresIn) : null,
|
|
]);
|
|
}
|
|
}
|