agent/php/Console/Commands/BrainPruneCommand.php
Snider 83df8ad71a fix(agent): address CodeRabbit + SonarCloud findings on PR #6
20+ CHANGES_REQUESTED dispositions across PHP MCP services, Go pkg/agentic,
hermes_runner_mcp Python server, plugin shell scripts.

Highlights:
- DatabaseSchema.php: identifier quoting
- AwardCredits.php: task row locking order
- CreditTransaction.php: fail-fast row decoding
- OpenApiGenerator.php: YAML parse handling + uri query params
- CaptureDispatchResultJob.php: AgentProfile namespace fix
- CreditsController.php: missing workspace_id fail-closed
- QueryAuditService.php: prose query false positives + unbounded aggregation
- McpHealthService.php: proc_close after timeout + env var resolution
- CreditLedger.php + FleetOverview.php: workspace agent + dispatch target validation
- McpAgentServerCommand.php: quota burn on failed tool calls
- McpMetricsService.php: N-day window consistency
- hermes_runner_mcp: API key off command line + invalid method+id + run_id encoding
- CircuitBreaker.php: extracted CircuitOpenException class with autoload-correct placement
- pkg/agentic + brain + flow: SonarCloud sendMessage/fetchLoopRepoRefs/commitWorkspace/Connect annotations
- shell scripts: removed [[ usage for portability

43 files modified, 1 new (CircuitOpenException.php).

Verification: gofmt -w + php -l + python3 -m py_compile + bash -n all clean.
Touched-package go test passes (pkg/lib/flow, pkg/lib).
Full go test ./... blocked by pre-existing dappco.re module graph drift, out of scope.

Parked for separate work:
- Mantis #1062: go.mod local replace removal (cross-repo architectural)
- Mantis #1063: Sonar residual line-length / duplication quality-gate cluster

Closes findings on https://github.com/dAppCore/agent/pull/6

Co-authored-by: Codex <noreply@openai.com>
2026-04-27 13:39:24 +01:00

75 lines
2.2 KiB
PHP

<?php
// SPDX-License-Identifier: EUPL-1.2
declare(strict_types=1);
namespace Core\Mod\Agentic\Console\Commands;
use Core\Mod\Agentic\Jobs\DeleteFromIndex;
use Core\Mod\Agentic\Models\BrainMemory;
use Illuminate\Console\Command;
use Illuminate\Database\Eloquent\Collection;
class BrainPruneCommand extends Command
{
protected $signature = 'brain:prune
{--older-than=90 : Permanently delete memories soft-deleted more than this many days ago}
{--chunk=100 : Number of memories to process per chunk}
{--dry-run : Preview stale memories without dispatching jobs or deleting records}';
protected $description = 'Permanently delete stale soft-deleted OpenBrain memories';
public function handle(): int
{
$olderThan = $this->positiveIntegerOption('older-than');
$chunkSize = $this->positiveIntegerOption('chunk');
if ($olderThan === null || $chunkSize === null) {
return self::FAILURE;
}
$cutoff = now()->subDays($olderThan);
$query = BrainMemory::onlyTrashed()->where('deleted_at', '<', $cutoff);
$count = (clone $query)->count();
if ($count === 0) {
$this->info('No stale soft-deleted brain memories found.');
return self::SUCCESS;
}
if ((bool) $this->option('dry-run')) {
$this->info("DRY RUN: {$count} stale soft-deleted brain memory record(s) would be permanently deleted.");
return self::SUCCESS;
}
$pruned = 0;
$query->chunkById($chunkSize, function (Collection $memories) use (&$pruned): void {
foreach ($memories as $memory) {
DeleteFromIndex::dispatch((string) $memory->id, true);
$pruned++;
}
});
$this->info("Pruned {$pruned} stale soft-deleted brain memory record(s).");
return self::SUCCESS;
}
private function positiveIntegerOption(string $name): ?int
{
$option = $this->option($name);
$value = filter_var($option, FILTER_VALIDATE_INT);
if ($value === false || $value < 1) {
$this->error("--{$name} must be a positive integer.");
return null;
}
return $value;
}
}