core/agent
8
0
Fork 0
Code Issues 5 Pull requests Projects Releases Packages Wiki Activity Actions
agent/php/tests/Feature
History
Snider 83df8ad71a fix(agent): address CodeRabbit + SonarCloud findings on PR #6 
20+ CHANGES_REQUESTED dispositions across PHP MCP services, Go pkg/agentic,
hermes_runner_mcp Python server, plugin shell scripts.

Highlights:
- DatabaseSchema.php: identifier quoting
- AwardCredits.php: task row locking order
- CreditTransaction.php: fail-fast row decoding
- OpenApiGenerator.php: YAML parse handling + uri query params
- CaptureDispatchResultJob.php: AgentProfile namespace fix
- CreditsController.php: missing workspace_id fail-closed
- QueryAuditService.php: prose query false positives + unbounded aggregation
- McpHealthService.php: proc_close after timeout + env var resolution
- CreditLedger.php + FleetOverview.php: workspace agent + dispatch target validation
- McpAgentServerCommand.php: quota burn on failed tool calls
- McpMetricsService.php: N-day window consistency
- hermes_runner_mcp: API key off command line + invalid method+id + run_id encoding
- CircuitBreaker.php: extracted CircuitOpenException class with autoload-correct placement
- pkg/agentic + brain + flow: SonarCloud sendMessage/fetchLoopRepoRefs/commitWorkspace/Connect annotations
- shell scripts: removed [[ usage for portability

43 files modified, 1 new (CircuitOpenException.php).

Verification: gofmt -w + php -l + python3 -m py_compile + bash -n all clean.
Touched-package go test passes (pkg/lib/flow, pkg/lib).
Full go test ./... blocked by pre-existing dappco.re module graph drift, out of scope.

Parked for separate work:
- Mantis #1062: go.mod local replace removal (cross-repo architectural)
- Mantis #1063: Sonar residual line-length / duplication quality-gate cluster

Closes findings on https://github.com/dAppCore/agent/pull/6

Co-authored-by: Codex <noreply@openai.com>
2026-04-27 13:39:24 +01:00
..
Agentic feat(agentic): implement §9 Services (FleetService + CreditService + SessionService) (#849) 2026-04-25 05:28:49 +01:00
Api feat(agent/php): Phase 4 scheduler + Mantis webhook (#830 narrowed) 2026-04-26 01:03:31 +01:00
Brain feat(agent/brain): lift OpenBrain discovery features (search/discoverTags/listScopes) (#180) 2026-04-25 20:39:14 +01:00
Console feat(agent/php): artisan agentic:sync-profiles + agentic:dispatch-queue (#829) 2026-04-26 01:08:42 +01:00
Jobs feat(brain): add DeleteFromIndex job 2026-04-23 12:55:45 +01:00
Livewire revert fcb9c189e5 2026-04-23 12:32:57 +01:00
Mcp fix(agent): address CodeRabbit + SonarCloud findings on PR #6 2026-04-27 13:39:24 +01:00
Mod feat(agent/admin+hub): RFC foundation — admin scaffold + Hub global components 2026-04-25 21:09:22 +01:00
Pipeline refactor(forge): route ScanForWork + ManagePullRequest through MetaReader 2026-04-23 18:21:28 +01:00
Services feat(brain): make BrainService::remember() async via EmbedMemory job 2026-04-23 13:29:30 +01:00
Sync feat(sync): update WorkspaceState workflow progress on dispatch push 2026-04-23 18:10:17 +01:00
.gitkeep revert fcb9c189e5 2026-04-23 12:32:57 +01:00
AgentApiKeyServiceTest.php revert fcb9c189e5 2026-04-23 12:32:57 +01:00
AgentApiKeyTest.php revert fcb9c189e5 2026-04-23 12:32:57 +01:00
AgenticGenerateCommandTest.php revert fcb9c189e5 2026-04-23 12:32:57 +01:00
AgentPhaseTest.php revert fcb9c189e5 2026-04-23 12:32:57 +01:00
AgentPlanTest.php revert fcb9c189e5 2026-04-23 12:32:57 +01:00
AgentProfileTest.php feat(agent/php): AgentProfile migration + Eloquent model + scopes (#825) 2026-04-26 00:34:24 +01:00
AgentSessionTest.php revert fcb9c189e5 2026-04-23 12:32:57 +01:00
ApiKeyManagerTest.php revert fcb9c189e5 2026-04-23 12:32:57 +01:00
BrainMemoryTest.php revert fcb9c189e5 2026-04-23 12:32:57 +01:00
BrainSeedMemoryCommandTest.php revert fcb9c189e5 2026-04-23 12:32:57 +01:00
BrainServiceTest.php feat(brain): add org filter to BrainService::buildQdrantFilter() 2026-04-23 12:32:58 +01:00
CaptureDispatchResultJobTest.php feat(agent/php): CaptureDispatchResultJob + MantisClient + ShaExtractor (#828) 2026-04-26 00:44:23 +01:00
ContentServiceTest.php revert fcb9c189e5 2026-04-23 12:32:57 +01:00
CreatePlanFromIssueTest.php revert fcb9c189e5 2026-04-23 12:32:57 +01:00
DispatchMantisTicketJobTest.php feat(agent/php): DispatchMantisTicketJob + HermesClient + agent_dispatches table (#827) 2026-04-26 00:52:37 +01:00
FleetControllerTest.php revert fcb9c189e5 2026-04-23 12:32:57 +01:00
ForAgentsControllerTest.php revert fcb9c189e5 2026-04-23 12:32:57 +01:00
ForgeActionsTest.php revert fcb9c189e5 2026-04-23 12:32:57 +01:00
ForgejoServiceTest.php revert fcb9c189e5 2026-04-23 12:32:57 +01:00
IpRestrictionServiceTest.php revert fcb9c189e5 2026-04-23 12:32:57 +01:00
IssueTest.php revert fcb9c189e5 2026-04-23 12:32:57 +01:00
PlanRetentionTest.php revert fcb9c189e5 2026-04-23 12:32:57 +01:00
PlanTemplateServiceTest.php revert fcb9c189e5 2026-04-23 12:32:57 +01:00
PromptVersionTest.php revert fcb9c189e5 2026-04-23 12:32:57 +01:00
ScanForWorkTest.php revert fcb9c189e5 2026-04-23 12:32:57 +01:00
SecurityTest.php revert fcb9c189e5 2026-04-23 12:32:57 +01:00
SessionControllerTest.php revert fcb9c189e5 2026-04-23 12:32:57 +01:00
SessionReplayTest.php revert fcb9c189e5 2026-04-23 12:32:57 +01:00
SprintTest.php revert fcb9c189e5 2026-04-23 12:32:57 +01:00
TaskCommandTest.php revert fcb9c189e5 2026-04-23 12:32:57 +01:00
TemplateVersionManagementTest.php revert fcb9c189e5 2026-04-23 12:32:57 +01:00
WorkspaceStateTest.php revert fcb9c189e5 2026-04-23 12:32:57 +01:00