agent/pkg/agentic/remote_client_test.go
Snider 277510ee16 test: 413 new tests — agentic 54.3%, setup 75.8%, all packages passing
Coverage: agentic 40.1% → 54.3%, setup 71.5% → 75.8%
Total: 695 passing tests across all packages (was ~357)

New test files (15):
- commands_forge_test.go — parseForgeArgs, fmtIndex
- commands_workspace_test.go — extractField (9 cases)
- commands_test.go — command registration + Core integration
- handlers_test.go — RegisterHandlers, IPC pipeline, lifecycle
- plan_crud_test.go — full CRUD via MCP handlers (23 tests)
- prep_extra_test.go — buildPrompt, findConsumersList, pullWikiContent, getIssueBody
- queue_extra_test.go — ConcurrencyLimit YAML, delayForAgent, drainOne
- remote_client_test.go — mcpInitialize, mcpCall, readSSEData, setHeaders
- remote_test.go — resolveHost, remoteToken
- resume_test.go — resume dry run, agent override, validation
- review_queue_test.go — countFindings, parseRetryAfter, buildAutoPRBody
- review_queue_extra_test.go — buildReviewCommand, rateLimitState, reviewQueue
- verify_extra_test.go — attemptVerifyAndMerge, autoVerifyAndMerge pipeline
- watch_test.go — findActiveWorkspaces, resolveWorkspaceDir
- setup/setup_extra_test.go — defaultBuildCommand, defaultTestCommand all branches

Co-Authored-By: Virgil <virgil@lethean.io>
2026-03-25 00:44:17 +00:00

174 lines
5.1 KiB
Go

// SPDX-License-Identifier: EUPL-1.2
package agentic
import (
"context"
"encoding/json"
"fmt"
"net/http"
"net/http/httptest"
"testing"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
)
// --- mcpInitialize ---
func TestMcpInitialize_Good(t *testing.T) {
callCount := 0
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
callCount++
assert.Equal(t, "POST", r.Method)
assert.Equal(t, "application/json", r.Header.Get("Content-Type"))
assert.Equal(t, "Bearer test-token", r.Header.Get("Authorization"))
if callCount == 1 {
// Initialize request
var body map[string]any
json.NewDecoder(r.Body).Decode(&body)
assert.Equal(t, "initialize", body["method"])
w.Header().Set("Mcp-Session-Id", "session-abc")
w.Header().Set("Content-Type", "text/event-stream")
fmt.Fprintf(w, "data: {\"result\":{}}\n\n")
} else {
// Initialized notification
w.WriteHeader(200)
}
}))
t.Cleanup(srv.Close)
sessionID, err := mcpInitialize(context.Background(), srv.Client(), srv.URL, "test-token")
require.NoError(t, err)
assert.Equal(t, "session-abc", sessionID)
assert.Equal(t, 2, callCount, "should make init + notification requests")
}
func TestMcpInitialize_Bad_ServerError(t *testing.T) {
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
w.WriteHeader(500)
}))
t.Cleanup(srv.Close)
_, err := mcpInitialize(context.Background(), srv.Client(), srv.URL, "")
assert.Error(t, err)
assert.Contains(t, err.Error(), "HTTP 500")
}
func TestMcpInitialize_Bad_Unreachable(t *testing.T) {
_, err := mcpInitialize(context.Background(), http.DefaultClient, "http://127.0.0.1:1", "")
assert.Error(t, err)
assert.Contains(t, err.Error(), "request failed")
}
// --- mcpCall ---
func TestMcpCall_Good(t *testing.T) {
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
assert.Equal(t, "Bearer mytoken", r.Header.Get("Authorization"))
assert.Equal(t, "sess-123", r.Header.Get("Mcp-Session-Id"))
w.Header().Set("Content-Type", "text/event-stream")
fmt.Fprintf(w, "event: message\ndata: {\"result\":{\"content\":[{\"text\":\"hello\"}]}}\n\n")
}))
t.Cleanup(srv.Close)
body := []byte(`{"jsonrpc":"2.0","id":1,"method":"tools/call"}`)
result, err := mcpCall(context.Background(), srv.Client(), srv.URL, "mytoken", "sess-123", body)
require.NoError(t, err)
assert.Contains(t, string(result), "hello")
}
func TestMcpCall_Bad_HTTP500(t *testing.T) {
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
w.WriteHeader(500)
}))
t.Cleanup(srv.Close)
_, err := mcpCall(context.Background(), srv.Client(), srv.URL, "", "", nil)
assert.Error(t, err)
assert.Contains(t, err.Error(), "HTTP 500")
}
func TestMcpCall_Bad_NoSSEData(t *testing.T) {
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
w.Header().Set("Content-Type", "text/event-stream")
fmt.Fprintf(w, "event: ping\n\n") // No data: line
}))
t.Cleanup(srv.Close)
_, err := mcpCall(context.Background(), srv.Client(), srv.URL, "", "", nil)
assert.Error(t, err)
assert.Contains(t, err.Error(), "no data")
}
// --- setHeaders ---
func TestSetHeaders_Good_All(t *testing.T) {
req, _ := http.NewRequest("POST", "http://example.com", nil)
setHeaders(req, "my-token", "my-session")
assert.Equal(t, "application/json", req.Header.Get("Content-Type"))
assert.Equal(t, "application/json, text/event-stream", req.Header.Get("Accept"))
assert.Equal(t, "Bearer my-token", req.Header.Get("Authorization"))
assert.Equal(t, "my-session", req.Header.Get("Mcp-Session-Id"))
}
func TestSetHeaders_Good_NoToken(t *testing.T) {
req, _ := http.NewRequest("POST", "http://example.com", nil)
setHeaders(req, "", "")
assert.Empty(t, req.Header.Get("Authorization"))
assert.Empty(t, req.Header.Get("Mcp-Session-Id"))
}
// --- readSSEData ---
func TestReadSSEData_Good(t *testing.T) {
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
w.Header().Set("Content-Type", "text/event-stream")
fmt.Fprintf(w, "event: message\ndata: {\"key\":\"value\"}\n\n")
}))
t.Cleanup(srv.Close)
resp, err := http.Get(srv.URL)
require.NoError(t, err)
defer resp.Body.Close()
data, err := readSSEData(resp)
require.NoError(t, err)
assert.Equal(t, `{"key":"value"}`, string(data))
}
func TestReadSSEData_Bad_NoData(t *testing.T) {
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
fmt.Fprintf(w, "event: ping\n\n")
}))
t.Cleanup(srv.Close)
resp, err := http.Get(srv.URL)
require.NoError(t, err)
defer resp.Body.Close()
_, err = readSSEData(resp)
assert.Error(t, err)
assert.Contains(t, err.Error(), "no data")
}
// --- drainSSE ---
func TestDrainSSE_Good(t *testing.T) {
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
fmt.Fprintf(w, "data: line1\ndata: line2\n\n")
}))
t.Cleanup(srv.Close)
resp, err := http.Get(srv.URL)
require.NoError(t, err)
defer resp.Body.Close()
// Should not panic
drainSSE(resp)
}